Fix JSON decoding in AlgodHTTPError (#223)

* Fix JSON decoding in AlgodHTTPError

* Add logging around error

* Apply same fix to indexer

* Fix integration tests

Author: aldur

algosdk/v2client/algod.py

@@ -84,8 +84,8 @@ def algod_request(
             code = e.code
             e = e.read().decode("utf-8")
             try:
-                raise error.AlgodHTTPError(json.loads(e)["message"], code)
-            except:
+                e = json.loads(e)["message"]
+            finally:
                 raise error.AlgodHTTPError(e, code)
         if response_format == "json":
             try:

algosdk/v2client/indexer.py

@@ -75,8 +75,8 @@ def indexer_request(
         except urllib.error.HTTPError as e:
             e = e.read().decode("utf-8")
             try:
-                raise error.IndexerHTTPError(json.loads(e)["message"])
-            except:
+                e = json.loads(e)["message"]
+            finally:
                 raise error.IndexerHTTPError(e)
         response_dict = json.loads(resp.read().decode("utf-8"))
 

test/steps/v2_steps.py

@@ -97,7 +97,7 @@ def step_impl(context, filename, directory, status):
 def validate_error(context, err):
     if context.expected_status_code != 200:
         if context.expected_status_code == 500:
-            assert context.expected_mock_response == json.loads(err.args[0])
+            assert context.expected_mock_response['message'] == err.args[0], (context.expected_mock_response, err.args[0])
         else:
             raise NotImplementedError(
                 "test does not know how to validate status code "

test_integration.py

@@ -513,6 +513,7 @@ def test_transaction_group(self):
             send = self.acl.send_transactions([stxn1])
             self.assertEqual(send, txn.get_txid())
         except error.AlgodHTTPError as ex:
+            self.assertNotIn('{"message"', str(ex))
             self.assertIn(
                 "TransactionPool.Remember: transaction groups not supported",
                 str(ex),