further simplify

Author: cce

network/wsNetwork.go

@@ -1187,14 +1187,16 @@ func (wn *WebsocketNetwork) maybeSendMessagesOfInterest(peer *wsPeer, messagesOf
 	peerMessagesOfInterestGeneration := peer.messagesOfInterestGeneration.Load()
 	if peerMessagesOfInterestGeneration != messagesOfInterestGeneration {
 		peerSupportsStatefulCompression := peer.vpackStatefulCompressionSupported()
-		sendEnc := messagesOfInterestEnc
+		if messagesOfInterestEnc == nil {
+			wn.messagesOfInterestMu.Lock()
+			messagesOfInterestEnc = wn.messagesOfInterestEnc
+			wn.messagesOfInterestMu.Unlock()
+		}
+
 		var perPeerTags map[protocol.Tag]bool
-		if sendEnc == nil || !peerSupportsStatefulCompression {
+		if !peerSupportsStatefulCompression {
 			wn.messagesOfInterestMu.Lock()
-			if sendEnc == nil {
-				sendEnc = wn.messagesOfInterestEnc
-			}
-			if !peerSupportsStatefulCompression && wn.messagesOfInterest[protocol.VotePackedTag] {
+			if wn.messagesOfInterest[protocol.VotePackedTag] {
 				// Filter VP tag for peers lacking stateful compression support; older nodes (<= v4.3)
 				// treat unknown tags as protocol violations and disconnect.
 				perPeerTags = make(map[protocol.Tag]bool, len(wn.messagesOfInterest))
@@ -1204,12 +1206,15 @@ func (wn *WebsocketNetwork) maybeSendMessagesOfInterest(peer *wsPeer, messagesOf
 					}
 					perPeerTags[tag] = flag
 				}
-				sendEnc = marshallMessageOfInterestMap(perPeerTags)
 			}
 			wn.messagesOfInterestMu.Unlock()
+
+			if perPeerTags != nil {
+				messagesOfInterestEnc = marshallMessageOfInterestMap(perPeerTags)
+			}
 		}
-		if sendEnc != nil {
-			peer.sendMessagesOfInterest(messagesOfInterestGeneration, sendEnc)
+		if messagesOfInterestEnc != nil {
+			peer.sendMessagesOfInterest(messagesOfInterestGeneration, messagesOfInterestEnc)
 		} else {
 			wn.log.Infof("msgOfInterest Enc=nil, MOIGen=%d", messagesOfInterestGeneration)
 		}