Skip to content

Commit f2e883c

Browse files
committed
addressing review comments
1 parent e318366 commit f2e883c

File tree

1 file changed

+18
-12
lines changed

1 file changed

+18
-12
lines changed

runtime/binding-http-kafka/src/main/java/io/aklivity/zilla/runtime/binding/http/kafka/internal/config/HttpKafkaOptionsConfigAdapter.java

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import jakarta.json.bind.adapter.JsonbAdapter;
2121

2222
import io.aklivity.zilla.runtime.binding.http.kafka.config.HttpKafkaCorrelationConfig;
23+
import io.aklivity.zilla.runtime.binding.http.kafka.config.HttpKafkaCorrelationConfigBuilder;
2324
import io.aklivity.zilla.runtime.binding.http.kafka.config.HttpKafkaIdempotencyConfig;
2425
import io.aklivity.zilla.runtime.binding.http.kafka.config.HttpKafkaOptionsConfig;
2526
import io.aklivity.zilla.runtime.binding.http.kafka.config.HttpKafkaOptionsConfigBuilder;
@@ -127,19 +128,24 @@ public OptionsConfig adaptFromJson(
127128

128129
if (object.containsKey(CORRELATION_NAME))
129130
{
130-
JsonObject correlation = object.getJsonObject(CORRELATION_NAME);
131-
if (correlation.containsKey(CORRELATION_HEADERS_NAME))
131+
JsonObject correlationJson = object.getJsonObject(CORRELATION_NAME);
132+
if (correlationJson.containsKey(CORRELATION_HEADERS_NAME))
132133
{
133-
JsonObject headers = correlation.getJsonObject(CORRELATION_HEADERS_NAME);
134-
135-
builder.correlation()
136-
.replyTo(headers.containsKey(CORRELATION_HEADERS_REPLY_TO_NAME)
137-
? headers.getString(CORRELATION_HEADERS_REPLY_TO_NAME)
138-
: null)
139-
.correlationId(headers.containsKey(CORRELATION_HEADERS_CORRELATION_ID_NAME)
140-
? headers.getString(CORRELATION_HEADERS_CORRELATION_ID_NAME)
141-
: null)
142-
.build();
134+
HttpKafkaCorrelationConfigBuilder<HttpKafkaOptionsConfigBuilder<HttpKafkaOptionsConfig>>
135+
correlation = builder.correlation();
136+
JsonObject headers = correlationJson.getJsonObject(CORRELATION_HEADERS_NAME);
137+
138+
if (headers.containsKey(CORRELATION_HEADERS_REPLY_TO_NAME))
139+
{
140+
correlation.replyTo(headers.getString(CORRELATION_HEADERS_REPLY_TO_NAME));
141+
}
142+
143+
if (headers.containsKey(CORRELATION_HEADERS_CORRELATION_ID_NAME))
144+
{
145+
correlation.correlationId(headers.getString(CORRELATION_HEADERS_CORRELATION_ID_NAME));
146+
}
147+
148+
correlation.build();
143149
}
144150
}
145151

0 commit comments

Comments
 (0)