Add sse, ws, fs extension parsing to dump command (#660)

Author: attilakreiner

incubator/command-dump/pom.xml

@@ -67,6 +67,24 @@
       <version>${project.version}</version>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>io.aklivity.zilla</groupId>
+      <artifactId>binding-sse.spec</artifactId>
+      <version>${project.version}</version>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>io.aklivity.zilla</groupId>
+      <artifactId>binding-ws.spec</artifactId>
+      <version>${project.version}</version>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>io.aklivity.zilla</groupId>
+      <artifactId>binding-filesystem.spec</artifactId>
+      <version>${project.version}</version>
+      <scope>test</scope>
+    </dependency>
     <dependency>
       <groupId>org.junit.jupiter</groupId>
       <artifactId>junit-jupiter-engine</artifactId>

incubator/command-dump/src/main/java/io/aklivity/zilla/runtime/command/dump/internal/airline/ZillaDumpCommand.java

@@ -299,51 +299,58 @@ public void run()
             .forEach(filtered::add);
         final LongPredicate filter = filtered.isEmpty() ? b -> true : filtered::contains;
 
-        try (Stream<Path> files = Files.walk(directory, 3);
-             WritableByteChannel writer = Files.newByteChannel(output, CREATE, WRITE, TRUNCATE_EXISTING))
-        {
-            final RingBufferSpy[] streamBuffers = files
-                .filter(this::isStreamsFile)
-                .sorted()
-                .peek(this::onDiscovered)
-                .map(this::createStreamBuffer)
-                .collect(Collectors.toList())
-                .toArray(RingBufferSpy[]::new);
-            final int streamBufferCount = streamBuffers.length;
-
-            final IdleStrategy idleStrategy = new BackoffIdleStrategy(MAX_SPINS, MAX_YIELDS, MIN_PARK_NS, MAX_PARK_NS);
-            final BindingsLayoutReader bindings = BindingsLayoutReader.builder().directory(directory).build();
-            final DumpHandler[] dumpHandlers = new DumpHandler[streamBufferCount];
-            for (int i = 0; i < streamBufferCount; i++)
+        if (output != null)
+        {
+            try (Stream<Path> files = Files.walk(directory, 3);
+                 WritableByteChannel writer = Files.newByteChannel(output, CREATE, WRITE, TRUNCATE_EXISTING))
             {
-                dumpHandlers[i] = new DumpHandler(i, filter, labels::lookupLabel, bindings.bindings()::get, writer);
-            }
+                final RingBufferSpy[] streamBuffers = files
+                    .filter(this::isStreamsFile)
+                    .sorted()
+                    .peek(this::onDiscovered)
+                    .map(this::createStreamBuffer)
+                    .collect(Collectors.toList())
+                    .toArray(RingBufferSpy[]::new);
+                final int streamBufferCount = streamBuffers.length;
+
+                final IdleStrategy idleStrategy = new BackoffIdleStrategy(MAX_SPINS, MAX_YIELDS, MIN_PARK_NS, MAX_PARK_NS);
+                final BindingsLayoutReader bindings = BindingsLayoutReader.builder().directory(directory).build();
+                final DumpHandler[] dumpHandlers = new DumpHandler[streamBufferCount];
+                for (int i = 0; i < streamBufferCount; i++)
+                {
+                    dumpHandlers[i] = new DumpHandler(i, filter, labels::lookupLabel, bindings.bindings()::get, writer);
+                }
 
-            final MutableDirectBuffer buffer = writeBuffer;
-            encodePcapGlobal(buffer);
-            writePcapOutput(writer, buffer, 0, PCAP_GLOBAL_SIZE);
+                final MutableDirectBuffer buffer = writeBuffer;
+                encodePcapGlobal(buffer);
+                writePcapOutput(writer, buffer, 0, PCAP_GLOBAL_SIZE);
 
-            final int exitWorkCount = continuous ? -1 : 0;
-            int workCount;
-            do
+                final int exitWorkCount = continuous ? -1 : 0;
+                int workCount;
+                do
+                {
+                    workCount = 0;
+                    for (int i = 0; i < streamBufferCount; i++)
+                    {
+                        final RingBufferSpy streamBuffer = streamBuffers[i];
+                        MessagePredicate spyHandler = dumpHandlers[i]::handleFrame;
+                        workCount += streamBuffer.spy(spyHandler, 1);
+                    }
+                    idleStrategy.idle(workCount);
+                } while (workCount != exitWorkCount);
+            }
+            catch (Exception ex)
             {
-                workCount = 0;
-                for (int i = 0; i < streamBufferCount; i++)
+                if (exceptions)
                 {
-                    final RingBufferSpy streamBuffer = streamBuffers[i];
-                    MessagePredicate spyHandler = dumpHandlers[i]::handleFrame;
-                    workCount += streamBuffer.spy(spyHandler, 1);
+                    ex.printStackTrace();
                 }
-                idleStrategy.idle(workCount);
-            } while (workCount != exitWorkCount);
+                rethrowUnchecked(ex);
+            }
         }
-        catch (Exception ex)
+        else if (verbose)
         {
-            if (exceptions)
-            {
-                ex.printStackTrace();
-            }
-            rethrowUnchecked(ex);
+            System.out.println("Output file not specified, exiting now.");
         }
     }