Cleanup Jetbrains Rider analyzer warnings (#7719)

* Cleanup Jetbrains Rider analyzer warnings

* Cleanup wrong comments

Author: Arkatufus

src/contrib/cluster/Akka.Cluster.Sharding/ClusterSharding.cs

@@ -229,7 +229,7 @@ public virtual ShardId ShardId(string entityId, Msg? messageHint = null)
     /// <para>
     /// Typical usage of this extension:
     ///   1. At system startup on each cluster node by registering the supported entity types with
-    /// the <see cref="ClusterSharding.Start"/> method
+    /// the <see cref="ClusterSharding.Start(string,Props,ClusterShardingSettings,IMessageExtractor)"/> method
     ///   1. Retrieve the <see cref="Sharding.ShardRegion"/> actor for a named entity type with <see cref="ClusterSharding.ShardRegion"/>
     /// Settings can be configured as described in the `akka.cluster.sharding` section of the `reference.conf`.
     /// </para>
@@ -291,9 +291,9 @@ public virtual ShardId ShardId(string entityId, Msg? messageHint = null)
     /// <para>
     /// '''Delivery Semantics''':
     /// As long as a sender uses the same <see cref="Sharding.ShardRegion"/> actor to deliver messages to an entity
-    /// actor the order of the messages is preserved. As long as the buffer limit is not reached
-    /// messages are delivered on a best effort basis, with at-most once delivery semantics,
-    /// in the same way as ordinary message sending. Reliable end-to-end messaging, with
+    /// actor the order of the messages is preserved. As long as the buffer limit is not reached,
+    /// messages will be delivered on a best effort basis, with at-most once delivery semantics,
+    /// in the same way as an ordinary message sending. Reliable end-to-end messaging, with
     /// at-least-once semantics can be added by using `AtLeastOnceDelivery` in `akka-persistence`.
     /// </para>
     /// <para>
@@ -1417,7 +1417,9 @@ public async Task<IActorRef> StartProxyAsync(string typeName, string role, IMess
 #pragma warning disable CS0419 // Ambiguous reference in cref attribute
         /// <summary>
         /// Retrieve the actor reference of the <see cref="Sharding.ShardRegion"/> actor responsible for the named entity type.
-        /// The entity type must be registered with the <see cref="ClusterSharding.Start"/> or <see cref="ClusterShardingGuardian.StartProxy"/> method before it
+        /// The entity type must be registered with the
+        /// <see cref="ClusterSharding.Start(string,Props,ClusterShardingSettings,IMessageExtractor)"/> or
+        /// <see cref="ClusterShardingGuardian.StartProxy"/> method before it
         /// can be used here. Messages to the entity is always sent via the <see cref="Sharding.ShardRegion"/>.
         /// </summary>
         /// <param name="typeName">TBD</param>

src/core/Akka.Cluster.Tests/MemberOrderingModelBasedTests.cs

@@ -56,7 +56,7 @@ public Property DistinctMemberAddressesMustCompareDifferently(Address[] addresse
                 a1 = a2; // next member
             }
 
-            return true.Classify(true, "all distinct").Classify(false, "empty set"); ;
+            return true.Classify(true, "all distinct").Classify(false, "empty set");
         }
     }
 

src/core/Akka.Persistence.TCK/Performance/JournalPerfSpec.cs

@@ -66,7 +66,7 @@ protected JournalPerfSpec(Config config, string actorSystem, ITestOutputHelper o
 
         internal IActorRef BenchActor(string pid, int replyAfter)
         {
-            return Sys.ActorOf(Props.Create(() => new BenchActor(pid, _testProbe, EventsCount, false)));;
+            return Sys.ActorOf(Props.Create(() => new BenchActor(pid, _testProbe, EventsCount, false)));
         }
 
         internal (IActorRef aut,TestProbe probe) BenchActorNewProbe(string pid, int replyAfter)

src/core/Akka.Remote.Tests/Transport/DotNettySslSupportSpec.cs

@@ -98,9 +98,7 @@ private static Config TestThumbprintConfig(string thumbPrint)
                     }
                 }
             }");
-            return false
-                ? config
-                : config.WithFallback(@"akka.remote.dot-netty.tcp.ssl {
+            return config.WithFallback(@"akka.remote.dot-netty.tcp.ssl {
                     suppress-validation = ""true""
                     certificate {
                         use-thumprint-over-file = true

src/core/Akka.Streams/Dsl/FlowWithContext.cs

@@ -54,7 +54,7 @@ public FlowWithContext<TIn, TCtxIn, TOut2, TCtx2, TMat3> ViaMaterialized<TOut2,
             FlowWithContext.From(Flow.FromGraph(Inner).ViaMaterialized(viaFlow, combine));
 
         /// <summary>
-        /// Context-preserving variant of <see cref="Flow{TIn, TOut, TMat2}.MapMaterializedValue{TMat2}(Func{TMat2, TMat2})"/>.
+        /// Context-preserving variant of <see cref="Flow{TIn, TOut, TMat}.MapMaterializedValue{TMat2}(Func{TMat, TMat2})"/>.
         /// </summary>
         public FlowWithContext<TIn, TCtxIn, TOut, TCtxOut, TMat2> MapMaterializedValue<TMat2>(Func<TMat, TMat2> combine) =>
             FlowWithContext.From(Flow.FromGraph(Inner).MapMaterializedValue(combine));

src/core/Akka.Streams/Dsl/Source.cs

@@ -649,7 +649,7 @@ public static Source<T, NotUsed> From<T>(IEnumerable<T> enumerable)
         /// beginning) regardless of when they subscribed.
         /// </summary>
         /// <typeparam name="T">TBD</typeparam>
-        /// <param name=" asyncEnumerable">TBD</param>
+        /// <param name="asyncEnumerable">TBD</param>
         /// <returns>TBD</returns>
         public static Source<T, NotUsed> From<T>(Func<IAsyncEnumerable<T>> asyncEnumerable)
             => FromGraph(new AsyncEnumerable<T>(asyncEnumerable)).WithAttributes(DefaultAttributes.EnumerableSource);

src/core/Akka.Streams/Dsl/SourceWithContext.cs

@@ -72,7 +72,7 @@ public IRunnableGraph<TMat3> ToMaterialized<TMat2, TMat3>(IGraph<SinkShape<(TOut
             Source.FromGraph(Inner).ToMaterialized(sink, combine);
 
         /// <summary>
-        /// Context-preserving variant of <see cref="Source{TOut, TMat2}.MapMaterializedValue{TMat2}(Func{TMat2, TMat2})"/>.
+        /// Context-preserving variant of <see cref="Source{TOut, TMat}.MapMaterializedValue{TMat2}(Func{TMat, TMat2})"/>.
         /// </summary>
         public SourceWithContext<TOut, TCtx, TMat2> MapMaterializedValue<TMat2>(Func<TMat, TMat2> combine) =>
             new(Source.FromGraph(Inner).MapMaterializedValue(combine));

src/core/Akka.Tests/Util/MessageBufferSpec.cs

@@ -39,7 +39,7 @@ public override string ToString()
 
         private IActorRef String2ActorRef(string s)
         {
-            return new DummyActorRef(s); ;
+            return new DummyActorRef(s);
         }
 
         [Fact]

src/core/Akka/Actor/ActorRef.cs

@@ -1014,7 +1014,10 @@ public FunctionRef(ActorPath path, IActorRefProvider provider, EventStream event
 
         public override ActorPath Path { get; }
         public override IActorRefProvider Provider { get; }
+        [Obsolete("Use Context.Watch and Receive<Terminated> [1.1.0]")]
+#pragma warning disable CS0809 
         public override bool IsTerminated => Volatile.Read(ref _watchedBy) == null;
+#pragma warning restore CS0809 
 
         /// <summary>
         /// Have this FunctionRef watch the given Actor. This method must not be

src/core/Akka/Pattern/RetrySupport.cs

@@ -118,14 +118,12 @@ Task<T> tryAttempt()
                         var nextAttempt = attempted + 1;
                         switch (delayFunction(nextAttempt))
                         {
-                            case Option<TimeSpan> delay when delay.HasValue:
+                            case { HasValue: true } delay:
                                 return delay.Value.Ticks < 1
                                     ? Retry(attempt, maxAttempts, delayFunction, nextAttempt, scheduler)
                                     : After(delay.Value, scheduler, () => Retry(attempt, maxAttempts, delayFunction, nextAttempt, scheduler));
-                            case Option<TimeSpan> _:
-                                return Retry(attempt, maxAttempts, delayFunction, nextAttempt, scheduler);
                             default:
-                                throw new InvalidOperationException("The delayFunction of Retry should not return null.");
+                                return Retry(attempt, maxAttempts, delayFunction, nextAttempt, scheduler);
                         }
                     }
                     return t;