Skip to content

Use SPDX license identifier for project metadata #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

Use SPDX license identifier for project metadata #1325

merged 1 commit into from
Apr 15, 2025

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Apr 13, 2025

Description of Change

PEP 639 specified the use of SPDX license expressions for license metadata.
Setuptools v77 added full support for it. However that version requires Python >=3.9.

Until 3.8 is dropped, I believe it makes sense to just use the SPDX identifier with the old license.text field.

https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license-and-license-files

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

Copy link

codecov bot commented Apr 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.79%. Comparing base (92142cd) to head (8e4ebbf).
Report is 38 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1325   +/-   ##
=======================================
  Coverage   90.79%   90.79%           
=======================================
  Files          68       68           
  Lines        6553     6553           
=======================================
  Hits         5950     5950           
  Misses        603      603           
Flag Coverage Δ
unittests 90.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@jakob-keller jakob-keller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, that makes sense to me. Could you please do a rebase on main?

@jakob-keller jakob-keller self-assigned this Apr 15, 2025
@jakob-keller jakob-keller added the documentation Improvements or additions to documentation label Apr 15, 2025
@cdce8p cdce8p requested a review from jakob-keller April 15, 2025 08:33
Copy link
Collaborator

@jakob-keller jakob-keller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, our approach to releasing and versioning is a bit weird. Could you please revert the version bump (2.22.0 is currently unreleased)?

Copy link
Collaborator

@jakob-keller jakob-keller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@jakob-keller jakob-keller enabled auto-merge April 15, 2025 08:46
@jakob-keller
Copy link
Collaborator

This project requires verified commit signatures: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

Could you please make sure your commits can be verified by GitHub? Otherwise, if you want, I could re-commit the changes for you to pass that blocker.

auto-merge was automatically disabled April 15, 2025 11:03

Head branch was pushed to by a user without write access

@cdce8p
Copy link
Contributor Author

cdce8p commented Apr 15, 2025

@jakob-keller Force pushed the commit to add the signature. Should be good now. Not sure why the one job is failing though. Looks unrelated.

@jakob-keller jakob-keller added this pull request to the merge queue Apr 15, 2025
Merged via the queue into aio-libs:master with commit fb2a2c2 Apr 15, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants