-
-
Notifications
You must be signed in to change notification settings - Fork 200
Use SPDX license identifier for project metadata #1325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1325 +/- ##
=======================================
Coverage 90.79% 90.79%
=======================================
Files 68 68
Lines 6553 6553
=======================================
Hits 5950 5950
Misses 603 603
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, that makes sense to me. Could you please do a rebase on main?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, our approach to releasing and versioning is a bit weird. Could you please revert the version bump (2.22.0 is currently unreleased)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
This project requires verified commit signatures: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification Could you please make sure your commits can be verified by GitHub? Otherwise, if you want, I could re-commit the changes for you to pass that blocker. |
Head branch was pushed to by a user without write access
@jakob-keller Force pushed the commit to add the signature. Should be good now. Not sure why the one job is failing though. Looks unrelated. |
Description of Change
PEP 639 specified the use of SPDX license expressions for
license
metadata.Setuptools
v77
added full support for it. However that version requires Python>=3.9
.Until
3.8
is dropped, I believe it makes sense to just use the SPDX identifier with the oldlicense.text
field.https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license-and-license-files
Checklist for All Submissions
Checklist when updating botocore and/or aiohttp versions