Skip to content

Commit 292bc51

Browse files
committed
update reproducibility and add model configurations for derpp_star, er_ace_star, er_star, and xder_rpc_star
1 parent b165ac0 commit 292bc51

File tree

7 files changed

+39
-7
lines changed

7 files changed

+39
-7
lines changed

REPRODUCIBILITY.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ The following table contains a list of models implemented in Mammoth and a check
2323
| ER-ACE LiDER | `er_ace_aer_abs` | V | |
2424
| ER-ACE with AER and ABS | `er_ace_lider` | V | |
2525
| ER-ACE with Tricks | `er_ace_tricks` | N/A | This method does not come from a paper. |
26-
| ER-ACE & STAR | `er_ace_star` | X | |
26+
| ER-ACE & STAR | `er_ace_star` | V | |
2727
| EwC Online | `ewc_on` | X | |
2828
| ER | `er` | N/A | This method predates modern benchmarks (R. Ratcliff. "Connectionist models of recognition memory: constraints imposed by learning and forgetting functions", 1990 -- A. Robins, "Catastrophic forgetting, rehearsal and pseudorehearsal", 1995) |
2929
| ER & STAR | `er_star` | V | |
@@ -62,4 +62,4 @@ The following table contains a list of models implemented in Mammoth and a check
6262
| X-DER | `xder` | V | |
6363
| X-DER with CE | `xder_ce` | V | |
6464
| X-DER with RPC | `xder_rpc` | V | |
65-
| X-DER with RPC & STAR | `xder_rpc_star` | X | |
65+
| X-DER with RPC & STAR | `xder_rpc_star` | V | |

models/config/derpp_star.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
seq-cifar10:
2+
100:
3+
alpha: 0.15
4+
beta: 0.15
5+
lr: 0.1
6+
model: derpp_star
7+
p_gamma: 0.05
8+
p_lam: 0.05

models/config/er_ace_star.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
seq-cifar10:
2+
100:
3+
lr: 0.03
4+
model: er_ace_star
5+
p_gamma: 0.01
6+
p_lam: 0.1
7+
seed: 4

models/config/er_star.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
seq-cifar10:
2+
100:
3+
lr: 0.1
4+
model: er_star
5+
p_gamma: 0.01
6+
p_lam: 0.1
7+
seed: 4

models/config/xder_rpc_star.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
seq-cifar10:
2+
100:
3+
alpha: 0.1
4+
beta: 0.5
5+
lr: 0.03
6+
model: xder_rpc_star
7+
p_gamma: 0.001
8+
p_lam: 0.01
9+
eta: 0.001
10+
seed: 4

models/xder_rpc_star.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ def get_parser(parser) -> ArgumentParser:
6767
parser.add_argument('--beta', type=float, required=True, help='Penalty weight.')
6868
add_perturb_args(parser)
6969
parser.add_argument('--gamma', type=float, default=0.85)
70-
parser.add_argument('--eta', type=float, default=0.1)
70+
parser.add_argument('--eta', type=float, default=0.001)
7171
parser.add_argument('--m', type=float, default=0.3)
7272

7373
parser.add_argument('--clip_grad', type=none_or_float, default=None, metavar='NORM', help='Clip gradient norm (default: None, no clipping)')

scripts/reproduce.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -323,27 +323,27 @@
323323
"setting": "class-il",
324324
"result": 61.76,
325325
"notes": "",
326-
"cmd": "--alpha=0.15 --beta=0.15 --buffer_size=100 --dataset=seq-cifar10 --lr=0.1 --model=derpp_star --p-gamma=0.05 --p-lam=0.05"
326+
"cmd": "--buffer_size=100 --dataset=seq-cifar10 --model=derpp_star --model_config=best"
327327
},
328328
{
329329
"model": "er_ace_star",
330330
"setting": "class-il",
331331
"result": 60.69,
332332
"notes": "",
333-
"cmd": "--buffer_size=100 --dataset=seq-cifar10 --lr=0.03 --model=er_ace_star --p-gamma=0.01 --p-lam=0.1"
333+
"cmd": "--buffer_size=100 --dataset=seq-cifar10 --model=er_ace_star --model_config=best"
334334
},
335335
{
336336
"model": "er_star",
337337
"setting": "class-il",
338338
"result": 51.5,
339339
"notes": "",
340-
"cmd": "--buffer_size=100 --dataset=seq-cifar10 --lr=0.1 --model=er_star --p-gamma=0.01 --p-lam=0.1"
340+
"cmd": "--buffer_size=100 --dataset=seq-cifar10 --model=er_star --model_config=best"
341341
},
342342
{
343343
"model": "xder_rpc_star",
344344
"setting": "class-il",
345345
"result": 58.85,
346346
"notes": "",
347-
"cmd": "--alpha=0.1 --beta=0.5 --buffer_size=100 --dataset=seq-cifar10 --lr=0.03 --model=xder_rpc_star --p-gamma=0.001 --p-lam=0.01"
347+
"cmd": "--buffer_size 100 --dataset=seq-cifar10 --model=xder_rpc_star --model_config=best"
348348
}
349349
]

0 commit comments

Comments
 (0)