Prefix reserved keywords in AsObject type #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Sorry for the late reply. Just merged PR & the latest new version 2.2.5 has been released. Thank you for your Issue & PR. |
Contributor
Author
|
No worries for the delay. Thanks for merging and thanks for the project. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a shot on fixing #20.
I'm not sure how you prefer to receive the build artefacts, but I've included them here as separate commits to make the changes clear.
The list of keywords is copied from the protoc javascript generator implementation here.
I've added a
SpecailCasesproto message, also from the protoc repo, in the examples (although it's not really part of that).Let me know what you think and if there is anything you prefer differently.