Skip to content

Commit 91ebc7a

Browse files
committed
upgrade to Gradle 6.6 (#54)
* to be able to use `--configuration-cache` in tests * because APIs changed again, see `forUseAtConfigurationTime()` Signed-off-by: Andreas Schmid <[email protected]>
1 parent 2816c63 commit 91ebc7a

File tree

5 files changed

+19
-23
lines changed

5 files changed

+19
-23
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ Explanation: v2.0 removes deprecated rendering API (= `net.sourceforge.pmd.cpd.R
5353
| [v2.0][] | 4.10.3 - 5.5 | >= 6.1.0 | >= 8 |
5454
| [v3.0][] | 5.6 - 5.x | >= 6.10.0 | >= 8 |
5555
| [v3.1][] | >= 5.6 | >= 6.10.0 | >= 8 |
56-
| [v3.2][] | >= 6.1 | >= 6.10.0 | >= 8 |
56+
| [v3.2][] | >= 6.6 | >= 6.10.0 | >= 8 |
5757

5858
¹: Java version may additionally depend on [PMD][]s version which is might not be properly reflected here.
5959

@@ -160,7 +160,7 @@ source = subprojects*.sourceSets*.main*.java*.srcDirs
160160
or
161161
```groovy
162162
source = subprojects*.sourceSets*.main*.java*.srcDirs + subprojects*.sourceSets*.test*.java*.srcDirs
163-
```
163+
```
164164
or
165165
```groovy
166166
cpdCheck {
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-6.1.1-all.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-6.6.1-all.zip
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists

gradlew

Lines changed: 12 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -154,19 +154,19 @@ if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then
154154
else
155155
eval `echo args$i`="\"$arg\""
156156
fi
157-
i=$((i+1))
157+
i=`expr $i + 1`
158158
done
159159
case $i in
160-
(0) set -- ;;
161-
(1) set -- "$args0" ;;
162-
(2) set -- "$args0" "$args1" ;;
163-
(3) set -- "$args0" "$args1" "$args2" ;;
164-
(4) set -- "$args0" "$args1" "$args2" "$args3" ;;
165-
(5) set -- "$args0" "$args1" "$args2" "$args3" "$args4" ;;
166-
(6) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" ;;
167-
(7) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" ;;
168-
(8) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" ;;
169-
(9) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" "$args8" ;;
160+
0) set -- ;;
161+
1) set -- "$args0" ;;
162+
2) set -- "$args0" "$args1" ;;
163+
3) set -- "$args0" "$args1" "$args2" ;;
164+
4) set -- "$args0" "$args1" "$args2" "$args3" ;;
165+
5) set -- "$args0" "$args1" "$args2" "$args3" "$args4" ;;
166+
6) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" ;;
167+
7) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" ;;
168+
8) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" ;;
169+
9) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" "$args8" ;;
170170
esac
171171
fi
172172

@@ -175,14 +175,9 @@ save () {
175175
for i do printf %s\\n "$i" | sed "s/'/'\\\\''/g;1s/^/'/;\$s/\$/' \\\\/" ; done
176176
echo " "
177177
}
178-
APP_ARGS=$(save "$@")
178+
APP_ARGS=`save "$@"`
179179

180180
# Collect all arguments for the java command, following the shell quoting and substitution rules
181181
eval set -- $DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS "\"-Dorg.gradle.appname=$APP_BASE_NAME\"" -classpath "\"$CLASSPATH\"" org.gradle.wrapper.GradleWrapperMain "$APP_ARGS"
182182

183-
# by default we should be in the correct project dir, but when run from Finder on Mac, the cwd is wrong
184-
if [ "$(uname)" = "Darwin" ] && [ "$HOME" = "$PWD" ]; then
185-
cd "$(dirname "$0")"
186-
fi
187-
188183
exec "$JAVACMD" "$@"

src/main/java/de/aaschmid/gradle/plugins/cpd/Cpd.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ private List<Report> createReportParameters(CpdReports reports) {
169169
String getEncodingOrFallback() {
170170
String encoding = getEncoding();
171171
if (encoding == null) {
172-
encoding = providerFactory.systemProperty("file.encoding").get();
172+
encoding = providerFactory.systemProperty("file.encoding").forUseAtConfigurationTime().get();
173173
}
174174
return encoding;
175175
}

src/test/java/de/aaschmid/gradle/plugins/cpd/test/PropertyUtils.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,21 @@
44

55
import org.gradle.api.internal.provider.DefaultListProperty;
66
import org.gradle.api.internal.provider.DefaultProperty;
7+
import org.gradle.api.internal.provider.PropertyHost;
78
import org.gradle.api.provider.ListProperty;
89
import org.gradle.api.provider.Property;
910

1011
public class PropertyUtils {
1112

1213
public static <T> Property<T> property(T t) {
1314
@SuppressWarnings("unchecked")
14-
Property<T> property = new DefaultProperty<T>((Class<T>) t.getClass());
15+
Property<T> property = new DefaultProperty<T>(PropertyHost.NO_OP, (Class<T>) t.getClass());
1516
property.set(t);
1617
return property;
1718
}
1819

1920
public static <T> ListProperty<T> listProperty(Class<T> clazz, List<T> list) {
20-
ListProperty<T> listProperty = new DefaultListProperty<>(clazz);
21+
ListProperty<T> listProperty = new DefaultListProperty<>(PropertyHost.NO_OP, clazz);
2122
listProperty.set(list);
2223
return listProperty;
2324
}

0 commit comments

Comments
 (0)