Skip to content

Commit 0866756

Browse files
committed
Corrected domain detection bug
1 parent 44cdf68 commit 0866756

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/updater/updater.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,11 @@ import (
2626
"reflect"
2727
"sync"
2828
"time"
29+
"github.com/op/go-logging"
2930
)
3031

32+
var logger = logging.MustGetLogger("cfdnsupdater.updater")
33+
3134
type DomainUpdater struct {
3235
domain string
3336
recordTypes core.RecordTypeSlice
@@ -133,9 +136,10 @@ SLEEP_PERIOD:
133136
zoneDetail.Name, recordDetail.Type, recordDetail.Name)
134137
recordIp := net.ParseIP(recordDetail.Content)
135138
recordType, convertErr := core.FromString(recordDetail.Type)
139+
136140
if !reflect.DeepEqual(recordIp, publicIP) && convertErr == nil &&
137-
(len(self.recordTypes) == 0 || (self.recordTypes.Contains(recordType))) &&
138-
(len(self.recordNames) == 0 || !utils.StringInSlice(recordDetail.Name,
141+
(len(self.recordTypes) == 0 || self.recordTypes.Contains(recordType)) &&
142+
(len(self.recordNames) == 0 || utils.StringInSlice(recordDetail.Name,
139143
self.recordNames)) {
140144
logger.Debugf("%s: Record %s:'%s' needs to be updated",
141145
self.domain, recordDetail.Type, recordDetail.Name)

0 commit comments

Comments
 (0)