Real-time collaboration: Hide lock modal based on user access to feature #72644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriszarate
added
[Feature] Real-time Collaboration
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +26 B (0%) Total Size: 2.19 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 477778d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18761675687
|
ingeniumed
reviewed
Oct 24, 2025
| } | ||
| // If both the current user and the lock owner can collaboratively edit, do not | ||
| // show the modal. | ||
| if ( syncEnabled && user.syncEnabled ) { |
There was a problem hiding this comment.
Alternative solution: could a filter be added on this syncEnabled property that allows it to be customized? So that way, a plugin like say our RTC plugin could use other factors to decide if it sync should be enabled or not. That way, we aren't tying this branch to our plugin and are opening the door to other plugins to make decisions on if sync should be enabled selectively or not.
There was a problem hiding this comment.
Yes, we could filter in 2-3 spots for the same effect. Still unlikely to be merged IMO.
pkevan
reviewed
Oct 24, 2025
| if ( globalThis.IS_GUTENBERG_PLUGIN ) { | ||
| return null; | ||
| } | ||
| // If both the current user and the lock owner can collaboratively edit, do not |
There was a problem hiding this comment.
Unless I'm misinterpreting the code, isn't this checking the user against the permissions of the post type since syncEnabled is checking for the experimental flag and the config of the post type?
There was a problem hiding this comment.
Yes. If the post type does not support collaborative editing, you also cannot collaboratively edit.
|
Closing this in favor of a different approach: Privileged users can turn off collaborative editing for a single post using a toggle or button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Hide the post lock modal based on user access to the collaborative editing feature.
Why?
If we want to allow users with access to the feature to exist alongside users without access, we need a way to selectively enforce the post lock.
How?
If both the current user and the lock owner have access to the collaborative editing feature, then we can safely ignore the post lock (but continue updating it in the background). Otherwise, defer to the current behavior of the post lock.
Testing Instructions
See Automattic/vip-real-time-collaboration#76
Testing Instructions for Keyboard
No UI changes in this PR.