Skip to content

Commit 2d24cd7

Browse files
paulhaunerWoodpile37
authored andcommitted
Make all validator monitor logs INFO (sigp#3727)
## Issue Addressed NA ## Proposed Changes This is a *potentially* contentious change, but I find it annoying that the validator monitor logs `WARN` and `ERRO` for imperfect attestations. Perfect attestation performance is unachievable (don't believe those photo-shopped beauty magazines!) since missed and poorly-packed blocks by other validators will reduce your performance. When the validator monitor is on with 10s or more validators, I find the logs are washed out with ERROs that are not worth investigating. I suspect that users who really want to know if validators are missing attestations can do so by matching the content of the log, rather than the log level. I'm open to feedback about this, especially from anyone who is relying on the current log levels. ## Additional Info NA ## Breaking Changes Notes The validator monitor will no longer emit `WARN` and `ERRO` logs for sub-optimal attestation performance. The logs will now be emitted at `INFO` level. This change was introduced to avoid cluttering the `WARN` and `ERRO` logs with alerts that are frequently triggered by the actions of other network participants (e.g., a missed block) and require no action from the user.
1 parent 9b95c5b commit 2d24cd7

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

beacon_node/beacon_chain/src/validator_monitor.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
55
use crate::metrics;
66
use parking_lot::RwLock;
7-
use slog::{crit, debug, error, info, warn, Logger};
7+
use slog::{crit, debug, info, Logger};
88
use slot_clock::SlotClock;
99
use state_processing::per_epoch_processing::{
1010
errors::EpochProcessingError, EpochProcessingSummary,
@@ -580,7 +580,7 @@ impl<T: EthSpec> ValidatorMonitor<T> {
580580
);
581581
}
582582
if !attestation_miss.is_empty() {
583-
error!(
583+
info!(
584584
self.log,
585585
"Previous epoch attestation(s) missing";
586586
"epoch" => prev_epoch,
@@ -589,7 +589,7 @@ impl<T: EthSpec> ValidatorMonitor<T> {
589589
}
590590

591591
if !head_miss.is_empty() {
592-
warn!(
592+
info!(
593593
self.log,
594594
"Previous epoch attestation(s) failed to match head";
595595
"epoch" => prev_epoch,
@@ -598,7 +598,7 @@ impl<T: EthSpec> ValidatorMonitor<T> {
598598
}
599599

600600
if !target_miss.is_empty() {
601-
warn!(
601+
info!(
602602
self.log,
603603
"Previous epoch attestation(s) failed to match target";
604604
"epoch" => prev_epoch,
@@ -607,7 +607,7 @@ impl<T: EthSpec> ValidatorMonitor<T> {
607607
}
608608

609609
if !suboptimal_inclusion.is_empty() {
610-
warn!(
610+
info!(
611611
self.log,
612612
"Previous epoch attestation(s) had sub-optimal inclusion delay";
613613
"epoch" => prev_epoch,

0 commit comments

Comments
 (0)