Skip to content

Commit 158ee9b

Browse files
authored
[NFC] Expand comment in TypeSSA (#8181)
Mention that rec group shapes can conflict because the binary writer can erase exactness, etc.
1 parent a5c9a30 commit 158ee9b

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/passes/TypeSSA.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,9 @@ std::vector<HeapType> ensureTypesAreInNewRecGroup(std::vector<HeapType>&& types,
7575
std::vector<HeapType> types(group.begin(), group.end());
7676
// N.B. we use `insertOrGet` rather than `insert` because some passes (DAE,
7777
// BlockMerging) can create multiple types with the same shape, so we can't
78-
// assume all the rec groups are already unique.
78+
// assume all the rec groups are already unique. The rec groups will have
79+
// different types, but their shapes will match considering how exactness,
80+
// etc. will be erased by the binary writer.
7981
unique.insertOrGet(std::move(types));
8082
}
8183

0 commit comments

Comments
 (0)