chore: cleanup deps and fix tests

Author: SimonSchick

.npmignore

@@ -51,7 +51,6 @@
   "devDependencies": {
     "@types/babel-code-frame": "^6.20.1",
     "@types/chokidar": "^1.7.5",
-    "@types/lodash": "^4.14.117",
     "@types/micromatch": "^3.1.0",
     "@types/minimatch": "^3.0.1",
     "@types/node": "^8.0.26",
@@ -87,10 +86,8 @@
     "babel-code-frame": "^6.22.0",
     "chalk": "^2.4.1",
     "chokidar": "^2.0.4",
-    "lodash": "^4.17.11",
     "micromatch": "^3.1.10",
     "minimatch": "^3.0.4",
-    "resolve": "^1.5.0",
     "tapable": "^1.0.0"
   },
   "husky": {

fork-ts-checker-webpack-plugin-v0.4.11.tgz

@@ -1,6 +1,5 @@
 import * as chokidar from 'chokidar';
 import * as path from 'path';
-import startsWith = require('lodash/startsWith');
 
 export class FilesWatcher {
   watchPaths: string[];
@@ -47,7 +46,7 @@ export class FilesWatcher {
     return (
       this.isWatching() &&
       this.isFileSupported(filePath) &&
-      this.watchPaths.some(watchPath => startsWith(filePath, watchPath))
+      this.watchPaths.some(watchPath => filePath.startsWith(watchPath))
     );
   }
 

package.json

@@ -1,5 +1,4 @@
 import * as fs from 'fs';
-import endsWith = require('lodash/endsWith');
 import * as path from 'path';
 import * as ts from 'typescript';
 import { Configuration, Linter, RuleFailure } from 'tslint'; // Imported for types alone; actual requires take place in methods below
@@ -21,15 +20,15 @@ interface ConfigurationFile extends Configuration.IConfigurationFile {
 }
 
 export class IncrementalChecker {
-  private programConfigFile: string;
-  private compilerOptions: object;
-  private linterConfigFile: string | false;
-  private linterAutoFix: boolean;
-  private watchPaths: string[];
-  private workNumber: number;
-  private workDivision: number;
-  private checkSyntacticErrors: boolean;
-  private files: FilesRegister;
+  programConfigFile: string;
+  compilerOptions: object;
+  linterConfigFile: string | false;
+  linterAutoFix: boolean;
+  watchPaths: string[];
+  workNumber: number;
+  workDivision: number;
+  checkSyntacticErrors: boolean;
+  files: FilesRegister;
 
   linter?: Linter;
   linterConfig?: ConfigurationFile;
@@ -155,7 +154,7 @@ export class IncrementalChecker {
     linterExclusions: minimatch.IMinimatch[]
   ): boolean {
     return (
-      endsWith(filePath, '.d.ts') ||
+      filePath.endsWith('.d.ts') ||
       linterExclusions.some(matcher => matcher.match(filePath))
     );
   }
@@ -304,7 +303,7 @@ export class IncrementalChecker {
       cancellationToken.throwIfCancellationRequested();
 
       try {
-        this.linter!.lint(fileName, undefined, this.linterConfig);
+        this.linter!.lint(fileName, undefined!, this.linterConfig); // REVIEW: this shouldn't work?
       } catch (e) {
         if (
           fs.existsSync(fileName) &&

src/FilesWatcher.ts

@@ -6,8 +6,6 @@ import * as fs from 'fs';
 import * as micromatch from 'micromatch';
 import * as os from 'os';
 import * as webpack from 'webpack';
-import isString = require('lodash/isString');
-import isFunction = require('lodash/isFunction');
 import { CancellationToken } from './CancellationToken';
 import { NormalizedMessage } from './NormalizedMessage';
 import { createDefaultFormatter } from './formatter/defaultFormatter';
@@ -131,7 +129,7 @@ class ForkTsCheckerWebpackPlugin {
         : options.tslint
       : undefined;
     this.tslintAutoFix = options.tslintAutoFix || false;
-    this.watch = isString(options.watch)
+    this.watch = (typeof options.watch === 'string')
       ? [options.watch]
       : options.watch || [];
     this.ignoreDiagnostics = options.ignoreDiagnostics || [];
@@ -147,7 +145,7 @@ class ForkTsCheckerWebpackPlugin {
     this.useColors = options.colors !== false; // default true
     this.colors = new chalk.constructor({ enabled: this.useColors });
     this.formatter =
-      options.formatter && isFunction(options.formatter)
+      options.formatter && (typeof options.formatter === 'function')
         ? options.formatter
         : ForkTsCheckerWebpackPlugin.createFormatter(
             (options.formatter as 'default' | 'codeframe') || 'default',

src/IncrementalChecker.ts

@@ -23,8 +23,6 @@
       "allow-pascal-case"
     ],
     "no-namespace": false,
-    "array-type": [true, "array"],
-    "no-submodule-imports": [true, "lodash"]
-
+    "array-type": [true, "array"]
   }
 }

src/index.ts

@@ -1,4 +1,5 @@
 {
   "compilerOptions": {
+      "lib": ["es2016"],
   }
 }

src/tslint.json

@@ -1,5 +1,7 @@
 {
-  "compilerOptions": {},
+  "compilerOptions": {
+      "lib": ["es2016", "dom"]
+  },
   "include": [
       "src/attrs/Test.vue",
       "src/attrs/NotFound.vue"

test/integration/project/tsconfig.json

@@ -8,7 +8,8 @@
               "imports/foo1/*",
               "imports/foo2/*"
           ]
-      }
+      },
+      "lib": ["es2016", "dom"]
   },
   "include": [
       "imports/Test.vue"