FINALLY IT WORKS FOR REAL

TwilightZebby · TwilightZebby · commit 83d22302e296 · 2025-09-10T10:56:25.000+01:00
diff --git a/Commands/ContextCommands/RoleMenus/Delete_Role_Menu.js b/Commands/ContextCommands/RoleMenus/Delete_Role_Menu.js
@@ -56,7 +56,7 @@ export const ContextCommand = {
         // Grab data
         const SourceMessage = interaction.data.resolved.messages[interaction.data.target_id];
         const SourceComponents = SourceMessage.components;
-        let checkForMenuType = SourceComponents[0].components.find(comp => comp.id === 30);
+        let checkForMenuType = SourceComponents[0].components.find(comp => comp.id === 8);
 
 
         // Validate Command was used on a Role Menu by this App
diff --git a/Commands/ContextCommands/RoleMenus/Edit_Role_Menu.js b/Commands/ContextCommands/RoleMenus/Edit_Role_Menu.js
@@ -57,7 +57,7 @@ export const ContextCommand = {
         // Grab data
         const SourceMessage = interaction.data.resolved.messages[interaction.data.target_id];
         const SourceComponents = SourceMessage.components;
-        let checkForMenuType = SourceComponents[0].components.find(comp => comp.id === 30);
+        let checkForMenuType = SourceComponents[0].components.find(comp => comp.id === 8);
 
 
         // Validate Command was used on a Role Menu by this App
diff --git a/Commands/SlashCommands/RoleMenus/rolemenu.js b/Commands/SlashCommands/RoleMenus/rolemenu.js
@@ -197,7 +197,7 @@ export const SlashCommand = {
                             "content": `-# ${localize(interaction.guild_locale, 'ROLE_MENU_REQUIREMENTS_PLACEHOLDER')}`
                         },
                         {
-                            "id": 30,
+                            "id": 8,
                             "type": ComponentType.TextDisplay,
                             "content": localize('en-GB', 'ROLE_MENU_MENU_TYPE_PLACEHOLDER')
                         }
diff --git a/Interactions/Buttons/RoleMenus/role.js b/Interactions/Buttons/RoleMenus/role.js
@@ -74,7 +74,7 @@ async function grantRevokeRole(interaction) {
     // Check for menu requirements
     const SourceMessage = interaction.message;
     const SourceComponents = SourceMessage.components;
-    let findMenuType = SourceComponents[0].components.find(component => component.id === 30);
+    let findMenuType = SourceComponents[0].components.find(component => component.id === 8);
     const SourceMenuType = findMenuType != undefined ? findMenuType.content.split(": ").pop() : undefined;
     let menuRequirementComponent = SourceComponents[0].components.find(component => component.id === 7);
 
diff --git a/Interactions/Modals/RoleMenus/menu-add-requirement.js b/Interactions/Modals/RoleMenus/menu-add-requirement.js
@@ -58,7 +58,7 @@ export const Modal = {
         });
 
         // Validation against Requirements
-        if ( MenuRequirements.includes(inputSelectedRole) ) {
+        if ( MenuRequirements.includes(`<@&${inputSelectedRole}>`) ) {
             return new JsonResponse({
                 type: InteractionResponseType.ChannelMessageWithSource,
                 data: {
diff --git a/Interactions/Modals/RoleMenus/menu-add-role.js b/Interactions/Modals/RoleMenus/menu-add-role.js
@@ -123,7 +123,7 @@ export const Modal = {
             // This is the very first button on the Menu
             MenuButtons.push({
                 "type": ComponentType.ActionRow,
-                "id": 8,
+                "id": 9,
                 "components": [newMenuButton]
             });
         }
@@ -168,7 +168,7 @@ export const Modal = {
         // Edit into Menu
         for ( let i = 0; i <= MenuButtons.length - 1; i++ ) {
             // This mess is just so I can pull each updated row out of MenuButtons and into MenuContainer.components, without having an Array where a Component Object should be
-            MenuContainer.components.splice(4 + i, 1, MenuButtons[i]);
+            MenuContainer.components.splice(5 + i, 1, MenuButtons[i]);
         }
         
         MenuContainer.components.forEach(comp => {
diff --git a/Interactions/Modals/RoleMenus/menu-edit-button.js b/Interactions/Modals/RoleMenus/menu-edit-button.js
@@ -84,7 +84,7 @@ export const Modal = {
         // Edit into Menu
         for ( let i = 0; i <= MenuButtons.length - 1; i++ ) {
             // This mess is just so I can pull each updated row out of MenuButtons and into MenuContainer.components, without having an Array where a Component Object should be
-            MenuContainer.components.splice(4 + i, 1, MenuButtons[i]);
+            MenuContainer.components.splice(5 + i, 1, MenuButtons[i]);
         }
         
         MenuContainer.components.forEach(comp => {
diff --git a/Interactions/Modals/RoleMenus/menu-remove-requirement.js b/Interactions/Modals/RoleMenus/menu-remove-requirement.js
@@ -49,7 +49,7 @@ export const Modal = {
 
 
         // Validate selected Role *is* an added Requirement that can be removed
-        if ( !(MenuRequirements.includes(inputSelectedRole)) ) {
+        if ( !(MenuRequirements.includes(`<@&${inputSelectedRole}>`)) ) {
             return new JsonResponse({
                 type: InteractionResponseType.ChannelMessageWithSource,
                 data: {
diff --git a/Interactions/Modals/RoleMenus/menu-remove-role.js b/Interactions/Modals/RoleMenus/menu-remove-role.js
@@ -91,7 +91,7 @@ export const Modal = {
                     // This is the very first button on the Menu
                     updatedMenuButtons.push({
                         "type": ComponentType.ActionRow,
-                        "id": 8,
+                        "id": 9,
                         "components": [button]
                     });
                 }
@@ -140,7 +140,7 @@ export const Modal = {
         // Edit into Menu
         for ( let i = 0; i <= MenuButtons.length - 1; i++ ) {
             // This mess is just so I can pull each updated row out of MenuButtons and into MenuContainer.components, without having an Array where a Component Object should be
-            MenuContainer.components.splice(4 + i, 1, MenuButtons[i]);
+            MenuContainer.components.splice(5 + i, 1, MenuButtons[i]);
         }
         
         MenuContainer.components.forEach(comp => {
diff --git a/Interactions/Modals/RoleMenus/menu-set-details.js b/Interactions/Modals/RoleMenus/menu-set-details.js
@@ -31,7 +31,7 @@ export const Modal = {
             if ( ModalComponents[i].type === ComponentType.Label ) {
                 let tempTopLevelComp = ModalComponents[i].component;
                 if ( tempTopLevelComp.custom_id === "menu-title" ) { inputMenuTitle = tempTopLevelComp.value; }
-                if ( tempTopLevelComp.custom_id === "menu-description" ) { inputMenuDescription = tempTopLevelComp.value ?? "\u200B"; }
+                if ( tempTopLevelComp.custom_id === "menu-description" ) { inputMenuDescription = tempTopLevelComp.value ?? "** **"; }
                 if ( tempTopLevelComp.custom_id === "menu-color" ) { inputMenuSidebarColor = tempTopLevelComp.value ?? undefined; }
             }
         }
diff --git a/Interactions/Modals/RoleMenus/menu-set-type.js b/Interactions/Modals/RoleMenus/menu-set-type.js
@@ -42,7 +42,7 @@ export const Modal = {
 
         MenuContainer.components.forEach(comp => {
             // Update Menu's type
-            if ( comp.id === 30 ) { comp.content = `${localize('en-GB', 'ROLE_MENU_TYPE_FOOTER', inputMenuType)}`; }
+            if ( comp.id === 8 ) { comp.content = `${localize('en-GB', 'ROLE_MENU_TYPE_FOOTER', inputMenuType)}`; }
         });
 
         // Put container back into message
diff --git a/Interactions/Selects/RoleMenus/create-role-menu.js b/Interactions/Selects/RoleMenus/create-role-menu.js
@@ -176,7 +176,7 @@ export const Select = {
                     "custom_id": `menu-description`,
                     "style": TextInputStyle.Paragraph,
                     "max_length": 2000,
-                    "required": false,
+                    "required": true,
                     "value": undefined
                 }
             }, {
diff --git a/Locales/en-GB.cjs b/Locales/en-GB.cjs
@@ -279,7 +279,7 @@ Use the Select Menu below to configure this Menu's Type, Embed and Role Buttons.
     ROLE_MENU_SET_MENU_DETAILS_MODAL_MENU_TITLE_LABEL: `Menu's Title`,
     ROLE_MENU_SET_MENU_DETAILS_MODAL_MENU_TITLE_DESCRIPTION: `Set the title of your Role Menu`,
     ROLE_MENU_SET_MENU_DETAILS_MODAL_MENU_DESCRIPTION_LABEL: `Menu's Description`,
-    ROLE_MENU_SET_MENU_DETAILS_MODAL_MENU_DESCRIPTION_LABEL_DESCRIPTION: `Set an optional description of your Role Menu`,
+    ROLE_MENU_SET_MENU_DETAILS_MODAL_MENU_DESCRIPTION_LABEL_DESCRIPTION: `Set a description for your Role Menu`,
     ROLE_MENU_SET_MENU_DETAILS_MODAL_MENU_COLOR_LABEL: `Menu's Colour`,
     ROLE_MENU_SET_MENU_DETAILS_MODAL_MENU_COLOR_DESCRIPTION: `Set the optional sidebar colour for your Role Menu. MUST be in a hex code format (eg: #ab44ff)`,
 
diff --git a/Locales/en-US.cjs b/Locales/en-US.cjs
@@ -279,7 +279,7 @@ Use the Select Menu below to configure this Menu's Type, Embed and Role Buttons.
     ROLE_MENU_SET_MENU_DETAILS_MODAL_MENU_TITLE_LABEL: `Menu's Title`,
     ROLE_MENU_SET_MENU_DETAILS_MODAL_MENU_TITLE_DESCRIPTION: `Set the title of your Role Menu`,
     ROLE_MENU_SET_MENU_DETAILS_MODAL_MENU_DESCRIPTION_LABEL: `Menu's Description`,
-    ROLE_MENU_SET_MENU_DETAILS_MODAL_MENU_DESCRIPTION_LABEL_DESCRIPTION: `Set an optional description of your Role Menu`,
+    ROLE_MENU_SET_MENU_DETAILS_MODAL_MENU_DESCRIPTION_LABEL_DESCRIPTION: `Set a description for your Role Menu`,
     ROLE_MENU_SET_MENU_DETAILS_MODAL_MENU_COLOR_LABEL: `Menu's Color`,
     ROLE_MENU_SET_MENU_DETAILS_MODAL_MENU_COLOR_DESCRIPTION: `Set the optional sidebar color for your Role Menu. MUST be in a hex code format (eg: #ab44ff)`,
 

Original file line number	Diff line number	Diff line change
`@@ -197,7 +197,7 @@ export const SlashCommand = {`
`197`	`197`	"content": `-# ${localize(interaction.guild_locale, 'ROLE_MENU_REQUIREMENTS_PLACEHOLDER')}`
`198`	`198`	`},`
`199`	`199`	`{`
`200`		`- "id": 30,`
	`200`	`+ "id": 8,`
`201`	`201`	`"type": ComponentType.TextDisplay,`
`202`	`202`	`"content": localize('en-GB', 'ROLE_MENU_MENU_TYPE_PLACEHOLDER')`
`203`	`203`	`}`
Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ export const Modal = {`
`84`	`84`	`// Edit into Menu`
`85`	`85`	`for ( let i = 0; i <= MenuButtons.length - 1; i++ ) {`
`86`	`86`	`// This mess is just so I can pull each updated row out of MenuButtons and into MenuContainer.components, without having an Array where a Component Object should be`
`87`		`- MenuContainer.components.splice(4 + i, 1, MenuButtons[i]);`
	`87`	`+ MenuContainer.components.splice(5 + i, 1, MenuButtons[i]);`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`MenuContainer.components.forEach(comp => {`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ export const Modal = {`
`31`	`31`	`if ( ModalComponents[i].type === ComponentType.Label ) {`
`32`	`32`	`let tempTopLevelComp = ModalComponents[i].component;`
`33`	`33`	`if ( tempTopLevelComp.custom_id === "menu-title" ) { inputMenuTitle = tempTopLevelComp.value; }`
`34`		`- if ( tempTopLevelComp.custom_id === "menu-description" ) { inputMenuDescription = tempTopLevelComp.value ?? "\u200B"; }`
	`34`	`+ if ( tempTopLevelComp.custom_id === "menu-description" ) { inputMenuDescription = tempTopLevelComp.value ?? " "; }`
`35`	`35`	`if ( tempTopLevelComp.custom_id === "menu-color" ) { inputMenuSidebarColor = tempTopLevelComp.value ?? undefined; }`
`36`	`36`	`}`
`37`	`37`	`}`