boolean-within check if line ends outside of poly (#2599)

kudlav · web-flow · commit c76e6e96eea2 · 2024-04-23T12:07:03.000-07:00
diff --git a/packages/turf-boolean-within/index.ts b/packages/turf-boolean-within/index.ts
@@ -173,7 +173,7 @@ function isLineInPoly(linestring: LineString, polygon: Polygon) {
   }
   var foundInsidePoint = false;
 
-  for (var i = 0; i < linestring.coordinates.length - 1; i++) {
+  for (var i = 0; i < linestring.coordinates.length; i++) {
     if (!booleanPointInPolygon(linestring.coordinates[i], polygon)) {
       return false;
     }
@@ -184,7 +184,7 @@ function isLineInPoly(linestring: LineString, polygon: Polygon) {
         { ignoreBoundary: true }
       );
     }
-    if (!foundInsidePoint) {
+    if (!foundInsidePoint && i < linestring.coordinates.length - 1) {
       var midpoint = getMidpoint(
         linestring.coordinates[i],
         linestring.coordinates[i + 1]

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,7 @@ function isLineInPoly(linestring: LineString, polygon: Polygon) {`
`173`	`173`	`}`
`174`	`174`	`var foundInsidePoint = false;`
`175`	`175`
`176`		`- for (var i = 0; i < linestring.coordinates.length - 1; i++) {`
	`176`	`+ for (var i = 0; i < linestring.coordinates.length; i++) {`
`177`	`177`	`if (!booleanPointInPolygon(linestring.coordinates[i], polygon)) {`
`178`	`178`	`return false;`
`179`	`179`	`}`
`@@ -184,7 +184,7 @@ function isLineInPoly(linestring: LineString, polygon: Polygon) {`
`184`	`184`	`{ ignoreBoundary: true }`
`185`	`185`	`);`
`186`	`186`	`}`
`187`		`- if (!foundInsidePoint) {`
	`187`	`+ if (!foundInsidePoint && i < linestring.coordinates.length - 1) {`
`188`	`188`	`var midpoint = getMidpoint(`
`189`	`189`	`linestring.coordinates[i],`
`190`	`190`	`linestring.coordinates[i + 1]`