Skip to content

Commit e5a2cef

Browse files
authored
fix(utils): reorder object disposal to avoid issue with Helper dispose methods (#683)
1 parent 6be07a5 commit e5a2cef

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/utils/index.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -295,6 +295,9 @@ export function disposeObject3D(object: TresObject): void {
295295
}
296296
else {
297297
const mesh = object as unknown as Partial<Mesh>
298+
if (object) {
299+
object.dispose?.()
300+
}
298301
if (mesh.geometry) {
299302
mesh.geometry.dispose()
300303
delete mesh.geometry
@@ -308,8 +311,5 @@ export function disposeObject3D(object: TresObject): void {
308311
disposeMaterial(mesh.material)
309312
delete mesh.material
310313
}
311-
if (object) {
312-
object.dispose?.()
313-
}
314314
}
315315
}

0 commit comments

Comments
 (0)