Skip to content

Commit d3d73d8

Browse files
StevenTCramerclaude
andcommitted
Clean up Directory.Build.props by removing commented-out code
Removed all the obsolete commented-out DateTime code and TODO comments, keeping only the clean working conditional solution for Windows/Linux. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent 3729f01 commit d3d73d8

File tree

1 file changed

+0
-20
lines changed

1 file changed

+0
-20
lines changed

TimeWarp.Architecture/Directory.Build.props

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -78,26 +78,6 @@
7878
<Exec Command="$(GitLogCommand)" ConsoleToMSBuild="true" Condition="'$(GitRepoAvailable)' == 'true'" StandardOutputImportance="Low" StandardErrorImportance="Low">
7979
<Output TaskParameter="ConsoleOutput" PropertyName="GitCommitTimestamp"/>
8080
</Exec>
81-
<!-- TODO: CRITICAL BUILD ISSUE ON LINUX - Fix DateTime expression
82-
The current DateTime.Parse().AddSeconds() approach fails on Linux with:
83-
"Method 'System.DateTime.AddSeconds' not found"
84-
85-
Need to implement the commented approach using System.DateTime.UnixEpoch.AddSeconds()
86-
See lines 92-94 for working alternative implementation
87-
88-
Tracked in Kanban task: 036_Fix-Directory-Build-Props-Linux-DateTime-Issue
89-
-->
90-
<!--<PropertyGroup Condition="'$(GitRepoAvailable)' == 'true'">
91-
Define the Unix epoch start date
92-
<UnixEpochStart>1970-01-01T00:00:00Z</UnixEpochStart>
93-
94-
Calculate the commit date in UTC from the timestamp
95-
<GitCommitDate>$([System.DateTime]::Parse($(UnixEpochStart)).AddSeconds($(GitCommitTimestamp)).ToUniversalTime().ToString('yyyy-MM-ddTHH:mm:ssK'))</GitCommitDate>
96-
97-
Assign the calculated date to LastCommitDate
98-
<LastCommitDate>$(GitCommitDate)</LastCommitDate>
99-
</PropertyGroup>-->
100-
10181
<!-- Windows: Use the working DateTime.Parse().AddSeconds() approach -->
10282
<PropertyGroup Condition="'$(GitRepoAvailable)' == 'true' AND '$(OS)' == 'Windows_NT'">
10383
<!-- Define the Unix epoch start date -->

0 commit comments

Comments
 (0)