Don't capture XUnit's Synchronization Context

TheCodeTraveler · TheCodeTraveler · commit b8b3f16ec466 · 2021-03-16T12:50:21.000-07:00
diff --git a/src/CommunityToolkit/Xamarin.CommunityToolkit/ObjectModel/Internals/BaseCommand.netstandard.wpf.cs b/src/CommunityToolkit/Xamarin.CommunityToolkit/ObjectModel/Internals/BaseCommand.netstandard.wpf.cs
@@ -6,7 +6,9 @@ namespace Xamarin.CommunityToolkit.ObjectModel.Internals
 {
 	public abstract partial class BaseCommand<TCanExecute>
 	{
-		readonly SynchronizationContext? synchronizationContext = SynchronizationContext.Current;
+		readonly SynchronizationContext? synchronizationContext = SynchronizationContext.Current?.GetType().FullName?.Contains("Xunit") is true // Ensures Xunit's Synchronization Context is not captured during Unit Testing (results in deadlock when captured) https://github.com/xunit/xunit/issues/883#issuecomment-226657173
+																	? null
+																	: SynchronizationContext.Current;
 
 		bool IsMainThread => SynchronizationContext.Current == synchronizationContext;
 

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,9 @@ namespace Xamarin.CommunityToolkit.ObjectModel.Internals`
`6`	`6`	`{`
`7`	`7`	`public abstract partial class BaseCommand<TCanExecute>`
`8`	`8`	`{`
`9`		`- readonly SynchronizationContext? synchronizationContext = SynchronizationContext.Current;`
	`9`	`+ readonly SynchronizationContext? synchronizationContext = SynchronizationContext.Current?.GetType().FullName?.Contains("Xunit") is true // Ensures Xunit's Synchronization Context is not captured during Unit Testing (results in deadlock when captured) https://github.com/xunit/xunit/issues/883#issuecomment-226657173`
	`10`	`+ ? null`
	`11`	`+ : SynchronizationContext.Current;`
`10`	`12`
`11`	`13`	`bool IsMainThread => SynchronizationContext.Current == synchronizationContext;`
`12`	`14`