Show consent banner on second app start

TobiGr · Stypox · web-flow · commit fd567f4a57e2 · 2024-03-27T21:27:20.000+01:00
Showing it on the first app start contributes to a bad onboarding an welcoming experience.

Co-authored-by: Stypox &lt;stypox@pm.me&gt;
diff --git a/app/src/main/java/org/schabi/newpipe/MainActivity.java b/app/src/main/java/org/schabi/newpipe/MainActivity.java
@@ -170,7 +170,8 @@ protected void onCreate(final Bundle savedInstanceState) {
             NotificationWorker.initialize(this);
         }
         if (!UpdateSettingsFragment.wasUserAskedForConsent(this)
-                && ReleaseVersionUtil.INSTANCE.isReleaseApk()) {
+                && ReleaseVersionUtil.INSTANCE.isReleaseApk()
+                && !App.getApp().isFirstRun()) {
             UpdateSettingsFragment.askForConsentToUpdateChecks(this);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,8 @@ protected void onCreate(final Bundle savedInstanceState) {`
`170`	`170`	`NotificationWorker.initialize(this);`
`171`	`171`	`}`
`172`	`172`	`if (!UpdateSettingsFragment.wasUserAskedForConsent(this)`
`173`		`- && ReleaseVersionUtil.INSTANCE.isReleaseApk()) {`
	`173`	`+ && ReleaseVersionUtil.INSTANCE.isReleaseApk()`
	`174`	`+ && !App.getApp().isFirstRun()) {`
`174`	`175`	`UpdateSettingsFragment.askForConsentToUpdateChecks(this);`
`175`	`176`	`}`
`176`	`177`	`}`