Revert "Don't compress most text files in states/movies (resolves #4415)"

This reverts commit 5cbc1de.

On principle of the previous revert, no acceptance of any Copilot or other ML tool code.

Author: CasualPokePlayer

src/BizHawk.Client.Common/movie/bk2/Bk2Movie.IO.cs

@@ -74,13 +74,12 @@ protected void AddBk2Lumps(ZipStateSaver bs)
 			bs.PutLump(BinaryStateLump.Comments, tw => tw.WriteLine(CommentsString()));
 			bs.PutLump(BinaryStateLump.Subtitles, tw => tw.WriteLine(Subtitles.ToString()));
 			bs.PutLump(BinaryStateLump.SyncSettings, tw => tw.WriteLine(SyncSettingsJson));
-			bs.PutLump(BinaryStateLump.Input, WriteInputLog, zstdCompress: true);
+			bs.PutLump(BinaryStateLump.Input, WriteInputLog);
 
 			if (StartsFromSavestate)
 			{
 				if (TextSavestate != null)
 				{
-					//TODO disable Zstd compression? are these meant to be editable?
 					bs.PutLump(BinaryStateLump.CorestateText, (TextWriter tw) => tw.Write(TextSavestate));
 				}
 				else

src/BizHawk.Client.Common/movie/tasproj/TasBranch.cs

@@ -150,7 +150,7 @@ public void Save(ZipStateSaver bs)
 					{
 						tw.WriteLine(b.InputLog[i]);
 					}
-				}, zstdCompress: true);
+				});
 
 				bs.PutLump(nframebuffer, s =>
 				{

src/BizHawk.Client.Common/movie/tasproj/TasMovie.IO.cs

@@ -21,7 +21,7 @@ private void AddTasProjLumps(ZipStateSaver bs, bool isBackup = false)
 
 			var settings = JsonConvert.SerializeObject(TasStateManager?.Settings ?? Session.Settings.DefaultTasStateManagerSettings);
 			bs.PutLump(BinaryStateLump.StateHistorySettings, tw => tw.WriteLine(settings));
-			bs.PutLump(BinaryStateLump.LagLog, tw => LagLog.Save(tw), zstdCompress: true);
+			bs.PutLump(BinaryStateLump.LagLog, tw => LagLog.Save(tw));
 			bs.PutLump(BinaryStateLump.Markers, tw => tw.WriteLine(Markers.ToString()));
 
 			if (InputRollSettingsForSave != null)
@@ -32,10 +32,7 @@ private void AddTasProjLumps(ZipStateSaver bs, bool isBackup = false)
 
 			if (VerificationLog.Count is not 0)
 			{
-				bs.PutLump(
-					BinaryStateLump.VerificationLog,
-					tw => tw.WriteLine(VerificationLog.ToInputLog()),
-					zstdCompress: true);
+				bs.PutLump(BinaryStateLump.VerificationLog, tw => tw.WriteLine(VerificationLog.ToInputLog()));
 			}
 
 			if (Branches.Count is not 0) Branches.Save(bs);

src/BizHawk.Client.Common/savestates/SavestateFile.cs

@@ -68,7 +68,6 @@ public void Create(string filename, SaveStateConfig config)
 			{
 				if (config.Type == SaveStateType.Text)
 				{
-					//TODO disable Zstd compression? are these meant to be editable?
 					bs.PutLump(BinaryStateLump.CorestateText, tw => _statable.SaveStateText(tw));
 				}
 				else
@@ -113,8 +112,7 @@ public void Create(string filename, SaveStateConfig config)
 						// this never should have been a core's responsibility
 						tw.WriteLine("Frame {0}", _emulator.Frame);
 						_movieSession.HandleSaveState(tw);
-					},
-					zstdCompress: true);
+					});
 			}
 
 			if (_userBag.Count is not 0)
@@ -129,10 +127,7 @@ public void Create(string filename, SaveStateConfig config)
 
 			if (_movieSession.Movie.IsActive() && _movieSession.Movie is ITasMovie)
 			{
-				bs.PutLump(
-					BinaryStateLump.LagLog,
-					tw => ((ITasMovie) _movieSession.Movie).LagLog.Save(tw),
-					zstdCompress: true);
+				bs.PutLump(BinaryStateLump.LagLog, tw => ((ITasMovie) _movieSession.Movie).LagLog.Save(tw));
 			}
 		}
 

src/BizHawk.Client.Common/savestates/ZipStateSaver.cs

@@ -53,14 +53,14 @@ public void PutLump(BinaryStateLump lump, Action<BinaryWriter> callback)
 			});
 		}
 
-		public void PutLump(BinaryStateLump lump, Action<TextWriter> callback, bool zstdCompress = false)
+		public void PutLump(BinaryStateLump lump, Action<TextWriter> callback)
 		{
 			PutLump(lump, s =>
 			{
 				TextWriter tw = new StreamWriter(s);
 				callback(tw);
 				tw.Flush();
-			}, zstdCompress: zstdCompress);
+			});
 		}
 
 		public void Dispose()