chore(waitlist): use Answers_v1 type in controller and service

Author: tyler-dane

packages/backend/src/waitlist/controller/waitlist.controller-add.test.ts

@@ -1,8 +1,5 @@
 import request from "supertest";
-import type {
-  Answers,
-  Answers_v1,
-} from "@core/types/waitlist/waitlist.answer.types";
+import type { Answers_v1 } from "@core/types/waitlist/waitlist.answer.types";
 
 describe("POST /api/waitlist", () => {
   beforeEach(() => jest.resetModules());
@@ -41,12 +38,13 @@ describe("POST /api/waitlist", () => {
     app.post("/api/waitlist", WaitlistController.addToWaitlist);
 
     const answers: Answers_v1 = {
+      email: "[email protected]",
+      schemaVersion: "1",
       source: "social-media",
       firstName: "Jo",
       lastName: "Schmo",
-      email: "[email protected]",
+      profession: "Founder",
       currentlyPayingFor: [],
-      schemaVersion: "1",
       anythingElse: "I'm a test",
     };
     const res = await request(app).post("/api/waitlist").send(answers);
@@ -66,16 +64,14 @@ describe("POST /api/waitlist", () => {
     app.use(express.json());
     app.post("/api/waitlist", WaitlistController.addToWaitlist);
 
-    const answers: Answers = {
+    const answers: Answers_v1 = {
+      email: "[email protected]",
+      schemaVersion: "1",
       source: "other",
       firstName: "Jo",
       lastName: "Schmo",
-      email: "[email protected]",
       currentlyPayingFor: [],
-      howClearAboutValues: "not-clear",
-      workingTowardsMainGoal: "yes",
-      isWillingToShare: false,
-      schemaVersion: "0",
+      profession: "Founder",
     };
     const res = await request(app).post("/api/waitlist").send(answers);
     expect(res.status).toBe(500);

packages/backend/src/waitlist/service/waitlist.service.ts

@@ -1,7 +1,7 @@
 import { Logger } from "@core/logger/winston.logger";
 import { mapWaitlistUserToEmailSubscriber } from "@core/mappers/subscriber/map.subscriber";
 import { Subscriber } from "@core/types/email/email.types";
-import { Answers } from "@core/types/waitlist/waitlist.answer.types";
+import { Answers_v1 } from "@core/types/waitlist/waitlist.answer.types";
 import {
   Result_InviteToWaitlist,
   Result_Waitlist,
@@ -16,7 +16,7 @@ const logger = Logger("app:waitlist.service");
 class WaitlistService {
   static async addToWaitlist(
     email: string,
-    answer: Answers,
+    answer: Answers_v1,
   ): Promise<Result_Waitlist> {
     if (ENV.EMAILER_SECRET && ENV.EMAILER_WAITLIST_TAG_ID) {
       const subscriber: Subscriber = {