Skip to content

Commit d3454f4

Browse files
committed
Merge pull request #20 from peaksandpies/master
New DNS option to start the docker container with
2 parents 49f92a1 + 0906f25 commit d3454f4

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

config/config.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ <h3>Docker Runner</h3>
33
Jobs are run inside docker containers!
44
</p>
55
<input ng-model="config.image" placeholder="Docker image to use. Default: strider/strider-docker-slave" class="input-block-level input-xxlarge" type="text">
6+
<input ng-model="config.dns" placeholder="comma separated list of dns servers, default: 8.8.8.8" class="input-block-level input-xxlarge" type="text">
67
<label class="checkbox">
78
<input type="checkbox" ng-model="config.privileged">
89
Should the image run in privileged mode? WARNING: Don't run insecure code in privileged mode.

lib/create-container.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ module.exports = function (createOptions, docker, config, done) {
2323
container.start({
2424
Privileged: config.privileged,
2525
PublishAllPorts: config.publishPorts,
26+
Dns: config.dns,
2627
}, function(err, data) {
2728
if(err) return done(new Error(err))
2829
container.wait(function(err, data) {

lib/run.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,15 @@ module.exports = function (docker, job, provider, plugins, config, next) {
1212
}
1313
})
1414
var slaveConfig = _.extend({
15-
id: job._id,
15+
id: job._id,
1616
dataDir: config.dataDir,
1717
image: 'strider/strider-docker-slave',
1818
env: env,
1919
}, config.branchConfig.runner.config)
2020
slaveConfig.image = slaveConfig.image || "strider/strider-docker-slave"
21+
if (slaveConfig.dns && slaveConfig.dns.length > 6) {
22+
slaveConfig.dns = slaveConfig.dns.split(",")
23+
}
2124
config.io.emit('job.status.command.comment', job._id, {
2225
comment: 'Creating docker container from ' + slaveConfig.image,
2326
plugin: 'docker',

0 commit comments

Comments
 (0)