Fix file permissions of /opt/stackstorm/packs and /opt/stackstorm/virtualenvs #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tualenvs not being idempotent and also being inefficient.
8 tasks
Member
Author
|
@armab this is ready for review now (got the unit tests passing) |
bishopbm1
pushed a commit
to EncoreTechnologies/puppet-st2
that referenced
this pull request
May 20, 2022
…sions Fix file permissions of /opt/stackstorm/packs and /opt/stackstorm/virtualenvs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #278
Previously
/opt/stackstorm/packsand/opt/stackstorm/virtualenvswas managed by afileresource withrecurse => true. This was VERY inefficient and also is not idempotent due to bad ordering. This PR fixes the idempotent ordering flaw by moving the resources into the proper spot (in theserverconfiguration) and also fix the efficiency by utilizing a new modulenpwalker/recursive_file_permissions