Skip to content

Conversation

@zinic
Copy link
Contributor

@zinic zinic commented Aug 30, 2023

Description

In a parallel BFS traversal, it's possible that some workers are unable to start due to connection slots being unavailable. This can result in a situation where the traversal naturally finishes but because workers are locked into waiting for a connection slot, they surface the context cancellation as a failure.

Motivation and Context

Log noise and better behaved traversal.

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

Copy link
Contributor

@rvazarkar rvazarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zinic zinic merged commit 68f37a8 into main Aug 31, 2023
@zinic zinic deleted the traversal-ctx-fix branch August 31, 2023 16:55
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants