-
Notifications
You must be signed in to change notification settings - Fork 271
chore: update dependencies #1935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdates CI vuln scanner action and upgrades/resolves several frontend dependencies: adjusts root package resolutions for dompurify/braces/tar-fs and bumps Font Awesome packages and jsdom in UI packages. No application source or public API changes detected. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (136)
📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (47)
.yarn/cache/@asamuzakjp-css-color-npm-4.0.5-aced85c302-8e115bfb00.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@asamuzakjp-dom-selector-npm-6.5.6-419f29e1af-2bd0fb1ebd.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@asamuzakjp-nwsapi-npm-2.3.9-9247524c07-5fe839eb5c.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@csstools-color-helpers-npm-5.1.0-d44a2a6134-2b1cef0093.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@csstools-css-calc-npm-2.1.4-81c74a3511-b833d1a031.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@csstools-css-color-parser-npm-3.1.0-005f6b530f-615d825fc7.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@csstools-css-parser-algorithms-npm-3.0.5-a0aa2fe05e-8064713957.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@csstools-css-syntax-patches-for-csstree-npm-1.0.14-e65a9adb88-383dc9e0f7.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@csstools-css-tokenizer-npm-3.0.4-342d48d326-adc6681d3a.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@fortawesome-fontawesome-free-npm-6.7.2-d3f6d6ec6d-2ceb384ada.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@fortawesome-fontawesome-svg-core-npm-6.7.2-e22b101297-b3c269545d.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@fortawesome-free-solid-svg-icons-npm-6.7.2-35f32a3213-457cc18039.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@fortawesome-react-fontawesome-npm-0.2.2-e1863961b2-e4bed35bfb.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@fortawesome-react-fontawesome-npm-3.0.2-8506c26a1f-86df127661.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@types-trusted-types-npm-2.0.7-a07fc44f59-8e4202766a.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/agent-base-npm-7.1.4-cb8b4604d5-86a7f542af.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/bidi-js-npm-1.0.3-0035393a88-877c5dcfd6.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/css-tree-npm-3.1.0-19cd308584-6b8c713c22.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/cssstyle-npm-5.3.1-bb38acb68d-08be443e77.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/data-urls-npm-6.0.0-f0731a6320-a47f0dde18.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/decimal.js-npm-10.6.0-a72c1b8a2f-9302b990cd.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/dompurify-npm-3.1.3-5c4e73330b-ad8bbf8f73.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/dompurify-npm-3.2.4-d8ea6c7c6a-7a299cbbfe.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/entities-npm-6.0.1-84692dab43-937b952e81.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/html-encoding-sniffer-npm-4.0.0-5f6627070d-3339b71dab.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/http-proxy-agent-npm-7.0.2-643ed7cc33-670858c8f8.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/https-proxy-agent-npm-7.0.6-27a95c2690-b882377a12.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/jsdom-npm-27.0.0-2830e3e1f9-a908333c52.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/lru-cache-npm-11.2.2-685f5506dc-052b3d0b81.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/mdn-data-npm-2.12.2-d75edd5e16-77f38c1802.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/parse5-npm-7.3.0-b0410074a3-ffd040c469.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/punycode-npm-2.3.1-97543c420d-bb0a0ceedc.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/require-from-string-npm-2.0.2-8557e0db12-a03ef68954.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/rrweb-cssom-npm-0.8.0-0c92f2366d-b84912cd1f.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/tar-fs-npm-2.1.4-90a454735f-a9e18e2e61.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/tldts-core-npm-7.0.16-2e9d473b9a-83006703fb.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/tldts-npm-7.0.16-210ecae11d-37a3b6df79.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/tough-cookie-npm-6.0.0-c7d0e8e15a-66d32ee40e.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/tr46-npm-6.0.0-86cfd34257-e7e95d847a.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/w3c-xmlserializer-npm-5.0.0-589edd7bff-593acc1fda.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/webidl-conversions-npm-8.0.0-29c7b11d7f-bcae2572af.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/whatwg-encoding-npm-3.1.1-7dfe21cf7d-f75a614224.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/whatwg-mimetype-npm-4.0.0-ebb293a688-f97edd4b4e.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/whatwg-url-npm-15.1.0-0889b0b826-30c7a3f9fc.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/ws-npm-8.18.3-665d39209d-d64ef16312.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/xml-name-validator-npm-5.0.0-0e0ec66944-86effcc702.zipis excluded by!**/.yarn/**,!**/*.zipyarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (3)
.github/workflows/vuln-scan.yml(1 hunks)package.json(1 hunks)packages/javascript/bh-shared-ui/package.json(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Build BloodHound Container Image / Build and Package Container
- GitHub Check: run-tests
- GitHub Check: run-analysis
- GitHub Check: build-ui
- GitHub Check: run-tests
🔇 Additional comments (3)
packages/javascript/bh-shared-ui/package.json (2)
24-29: Font Awesome upgrades: verify breaking changes in @fortawesome/react-fontawesome v3v3 switches to ESM and often requires disabling auto-injected CSS and importing styles explicitly. Ensure the app entry does the following if you rely on the default CSS:
// e.g., src/main.tsx import { config } from "@fortawesome/fontawesome-svg-core"; import "@fortawesome/fontawesome-svg-core/styles.css"; config.autoAddCss = false;Also confirm icons are imported using supported APIs for v6.
82-82: jsdom upgrade check passed CI uses Node 22 (LTS) and Vitest is configured withenvironment: 'jsdom'.package.json (1)
30-36: Approve top-level resolutions
Yarn lock only resolvesbracesto 3.0.3 andtar-fsto 2.1.4, with no other references. Optional: remove the extra space in thetar-fsrange (">=2.1.3 <3.0.0") for consistency.
|
|
||
| - name: Run vulnerability scanner | ||
| uses: aquasecurity/trivy-action@0.28.0 | ||
| uses: aquasecurity/trivy-action@0.33.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
🧩 Analysis chain
Pin the action to a commit SHA and confirm input compatibility with v0.33.1
For supply‑chain hardening, pin to the action’s commit SHA instead of a mutable tag. Also verify that scan-type: "repo" is a supported input for 0.33.1.
Please fetch the commit SHA and confirm supported inputs:
🌐 Web query:
What is the commit SHA for aquasecurity/[email protected], and is `scan-type: "repo"` a valid input for that version?
💡 Result:
- Commit SHA for aquasecurity/[email protected]: b6643a2 (tag v0.33.1 points to commit b6643a2). [1]
- Is scan-type: "repo" valid for that version? Yes — the action's inputs for that release include scan-type with allowed values image, fs, repo, rootfs, config (repo is supported). [2][3]
Sources:
[1] Release v0.33.1 — aquasecurity/trivy-action (GitHub).
[2] README / inputs — aquasecurity/trivy-action (GitHub).
[3] action inputs documentation showing scan-type includes "repo" (repository).
Pin aquasecurity/trivy-action to commit SHA b6643a2
In .github/workflows/vuln-scan.yml (line 37), replace
- uses: aquasecurity/[email protected]
+ uses: aquasecurity/trivy-action@b6643a2scan-type: "repo" is supported in v0.33.1.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| uses: aquasecurity/trivy-action@0.33.1 | |
| uses: aquasecurity/trivy-action@b6643a2 |
🤖 Prompt for AI Agents
.github/workflows/vuln-scan.yml around line 37: the workflow currently
references the action by tag `aquasecurity/[email protected]`; update the
`uses` entry to pin the action to the specific commit SHA `b6643a2` (i.e.,
`aquasecurity/trivy-action@b6643a2`) to ensure immutability and repeatable runs,
keeping existing inputs like `scan-type: "repo"` unchanged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.github/workflows/build-ui.yml (3)
45-47: Use frozen lockfile and enable caching (and consider Corepack over global Yarn).
- Prevent lockfile drift in CI and speed up installs.
Apply within this step:
- yarn + yarn --frozen-lockfileAdditionally (outside this hunk), consider:
- Caching Yarn deps via setup-node:
# under "uses: actions/setup-node@v4" with: node-version: 22 cache: yarn cache-dependency-path: | yarn.lock
- Using Corepack instead of globally installing Yarn (especially if the repo uses Yarn Berry):
- name: Install Yarn run: | npm install --global yarn +name: Enable Corepack (use repo-pinned Yarn) +run: | + corepack enable + corepack installCan you confirm whether the repo uses Yarn 1 (classic) or Berry so we can pick the right flags (
--frozen-lockfilevs--immutable)?
49-52: Run Prettier in check mode to fail on formatting drift.Ensure CI fails instead of mutating files transiently.
- yarn format + yarn format:checkIf
format:checkisn’t defined, alternatively:run: | yarn prettier --check .Please confirm the root package.json has an appropriate check script.
53-56: Verify thatyarn buildat repo root builds the intended UI/workspaces.In many monorepos,
yarn buildat root won’t traverse workspaces unless scripted (e.g.,yarn workspaces run build, Lerna, orworkspaces foreach).If needed (Yarn classic):
run: | yarn workspaces run buildOr target the specific UI package:
run: | yarn workspace <ui-package-name> buildPlease confirm the root build script fans out across the required packages.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/build-ui.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Build BloodHound Container Image / Build and Package Container
- GitHub Check: run-tests
- GitHub Check: run-tests
- GitHub Check: build-ui
- GitHub Check: run-analysis
235606c to
e1cdef3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.github/workflows/build-ui.yml (3)
47-47: Step name is misleadingThis step formats and builds multiple packages and installs UI deps; rename for clarity or split into dedicated steps.
Suggested name: “Install, format (check), and build UI packages”
47-47: Use working-directory, enable caching and Corepack
- Split into per-package steps with
working-directoryfor clearer logs.- Add
- uses: actions/setup-node@v4 with: node-version: 22 cache: yarn cache-dependency-path: | packages/javascript/js-client-library/yarn.lock packages/javascript/bh-shared-ui/yarn.lock cmd/ui/yarn.lock- If on Yarn Berry, replace global install with:
- name: Enable Corepack run: corepack enable- No
engines.nodefields were found—consider declaring supported Node versions or aligning thenode-versionabove to your project requirements.
47-47: Enforce immutable installs and non-mutating format checks in CI
- Split chained
cd+yarncommands withset -efor clarity and fail-fast behavior.- Use Yarn Berry’s
--immutableflag and runprettier --checkinstead of mutatingprettier --write.- cd packages/javascript/js-client-library && yarn && yarn format && yarn build && cd ../bh-shared-ui/ && yarn && yarn format && yarn build && cd ../../../cmd/ui/ && yarn + set -e + cd packages/javascript/js-client-library + yarn install --immutable + yarn prettier --check "src/**/*.@(js|jsx|ts|tsx|md|html|css|scss|json)" || (echo "Formatting issues in js-client-library" && exit 1) + yarn build + cd ../bh-shared-ui + yarn install --immutable + yarn prettier --check "src/**/*.@(js|jsx|ts|tsx|md|html|css|scss|json)" || (echo "Formatting issues in bh-shared-ui" && exit 1) + yarn build + cd ../../../cmd/ui + yarn install --immutableIf you’d rather add a
format:checkscript in eachpackage.json, invoke that instead of inlineprettier --check.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/build-ui.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: run-tests
🔇 Additional comments (1)
.github/workflows/build-ui.yml (1)
47-47: Summary mismatch: not running from repo rootAI summary mentions running yarn from the repository root, but this step cd’s into subdirectories. Confirm intended approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
cmd/ui/package.json (1)
25-27: Remove unused@fortawesome/fontawesome-freedependency
No imports of its CSS/webfont bundle or any.fa-*class usage detected. Drop
– the"@fortawesome/fontawesome-free": "^6.7.2"line in cmd/ui/package.json
– the'@fortawesome/fontawesome-free'entry in cmd/ui/vite.config.ts (optimizeDeps.include)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (5)
.yarn/cache/@fortawesome-fontawesome-common-types-npm-6.4.2-1f8b184e1e-4a22932bd0.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@fortawesome-fontawesome-free-npm-6.4.2-49cdde900e-14be8fbb8f.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@fortawesome-fontawesome-svg-core-npm-6.4.2-530d31922b-0c0ecd9058.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@fortawesome-free-solid-svg-icons-npm-6.4.2-c582f5c032-4a36500499.zipis excluded by!**/.yarn/**,!**/*.zipyarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (1)
cmd/ui/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Build BloodHound Container Image / Build and Package Container
- GitHub Check: build-ui
- GitHub Check: run-analysis
- GitHub Check: run-tests
- GitHub Check: run-tests
🔇 Additional comments (1)
cmd/ui/package.json (1)
25-27: LGTM: Font Awesome bumped to 6.7.2
Update is compatible with both @fortawesome/react-fontawesome @^0.2.x and @^3.x.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
cmd/ui/package.json (1)
91-91: jsdom ^27: compatibility OK in CI and tests. CI workflows use Node 22 (above jsdom 27’s minimum Node ≥16.17 requirement), Vitest runs injsdom, and no deprecated jsdom globals (MutationObserverInit, DOMParser, URLPattern) were found. Consider adding a rootenginesfield in package.json to enforce Node ≥16.17.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (23)
.yarn/cache/@fortawesome-react-fontawesome-npm-0.2.0-a36215138f-f652a0c217.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/abab-npm-2.0.6-2662fba7f0-6ffc1af4ff.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/acorn-globals-npm-7.0.1-97c48c0140-2a2998a547.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/acorn-walk-npm-8.3.2-df039a42bf-3626b9d26a.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/cssom-npm-0.3.8-a9291d36ff-24beb3087c.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/cssom-npm-0.5.0-44ab2704f2-823471aa30.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/cssstyle-npm-2.3.0-b5d112c450-5f05e6fd2e.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/decimal.js-npm-10.4.3-e7d483387c-796404dcfa.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/domexception-npm-4.0.0-5093673f9b-ddbc1268ed.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/entities-npm-4.5.0-7cdb83b832-853f8ebd5b.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/escodegen-npm-2.1.0-e0bf940745-096696407e.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/esprima-npm-4.0.1-1084e98778-b45bc805a6.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/jsdom-npm-20.0.3-906a2f7005-6e2ae21db3.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/nwsapi-npm-2.2.7-3bed340fab-cab25f7983.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/parse5-npm-7.1.2-aa9a92c270-59465dd05e.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/psl-npm-1.9.0-a546edad1a-20c4277f64.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/tough-cookie-npm-4.1.3-08285e2518-c9226afff3.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/tr46-npm-3.0.0-e1ae1ea7c9-44c3cc6767.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/universalify-npm-0.2.0-9984e61c10-e86134cb12.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/webidl-conversions-npm-7.0.0-e8c8e30c68-f05588567a.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/whatwg-encoding-npm-2.0.0-d7451f51b4-7087810c41.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/whatwg-url-npm-11.0.0-073529d93a-ed4826aaa5.zipis excluded by!**/.yarn/**,!**/*.zipyarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (1)
cmd/ui/package.json(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Build BloodHound Container Image / Build and Package Container
- GitHub Check: run-tests
- GitHub Check: build-ui
- GitHub Check: run-tests
- GitHub Check: run-analysis
🔇 Additional comments (1)
cmd/ui/package.json (1)
25-28: Double-check @fortawesome/react-fontawesome major bump and CSS kit usage.
- Verify
^3.0.2is intentional and that your imports/usages (FontAwesomeIcon,library.add) work with v3’s React >=18 / Node >=20 requirements.- Remove
@fortawesome/fontawesome-freeif you aren’t importing its CSS/fonts.
- updates font awesome deps - updates jsdom - updates trivy version in vuln scan workflow - sets resolution for `braces` resolves BED-6541
Description
bracesMotivation and Context
Resolves BED-6541
Why is this change required? What problem does it solve?
How Has This Been Tested?
Housekeeping. Vuln check passes for the braces dep
Screenshots (optional):
Types of changes
Checklist:
Summary by CodeRabbit
Chores
Documentation
Refactor
Bug Fixes
Tests
Style
Revert