-
Notifications
You must be signed in to change notification settings - Fork 271
chore: designate code owners for all npm and yarn related files #1894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds a new .github/CODEOWNERS file that defines ownership rules for NPM/Yarn-related files, mapping them to @superlinkx and @elikmiller, and notes that the last matching rule wins. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.github/CODEOWNERS (3)
5-11: Broaden coverage (.npmrc, npm-shrinkwrap) and simplify globs.
- Add .npmrc and npm-shrinkwrap.json (often security‑sensitive and dependency‑locking).
- Optional: drop the leading **/ for readability; bare patterns already match anywhere.
# NPM and Yarn files -**/package.json @superlinkx @elikmiller -**/package-lock.json @superlinkx @elikmiller -**/.yarn/** @superlinkx @elikmiller -**/.yarnrc @superlinkx @elikmiller -**/.yarnrc.yml @superlinkx @elikmiller -**/yarn.lock @superlinkx @elikmiller -**/yarn-workspaces.json @superlinkx @elikmiller +package.json @superlinkx @elikmiller +package-lock.json @superlinkx @elikmiller +npm-shrinkwrap.json @superlinkx @elikmiller +.npmrc @superlinkx @elikmiller +.yarn/** @superlinkx @elikmiller +.yarnrc @superlinkx @elikmiller +.yarnrc.yml @superlinkx @elikmiller +yarn.lock @superlinkx @elikmiller +yarn-workspaces.json @superlinkx @elikmiller
5-11: Prefer team aliases over individuals.To reduce bus factor and maintenance, consider a team (e.g., @SpecterOps/npm-owners) instead of direct user handles. If you create the team, swap it into all rules.
5-11: Enforce via branch protection.Make sure “Require review from Code Owners” is enabled on main so these entries actually gate merges, especially given the Shai‑Hulud supply‑chain concern.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/CODEOWNERS(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Build BloodHound Container Image / Build and Package Container
- GitHub Check: run-tests
- GitHub Check: build-ui
- GitHub Check: run-tests
- GitHub Check: run-analysis
🔇 Additional comments (2)
.github/CODEOWNERS (2)
1-3: Good placement and guidance.File is in a supported location and the “last matching rule wins” reminder is correct.
5-11: CODEOWNERS coverage OK — no changes required.Script found: package.json (root), cmd/ui/package.json, packages/javascript/bh-shared-ui/package.json, packages/javascript/js-client-library/package.json, yarn-workspaces.json, yarn.lock, .yarnrc.yml. No package-lock.json or npm-shrinkwrap.json detected.
Description
Designates codeowners for all NPM/Yarn related dependency management files
Motivation and Context
Resolves BED-6491
This is a proactive and preventative measure against the recently reported "Shai-Hulud" malware campaign.
See https://www.koi.security/blog/shai-hulud-npm-supply-chain-attack-crowdstrike-tinycolor for more details.
Summary by CodeRabbit