Skip to content

Conversation

@ddlees
Copy link
Member

@ddlees ddlees commented Oct 11, 2023

Description

  • Removes processing devices owners for AZExecuteCommand edge
  • Adds tests

Motivation and Context

AZExecuteCommand should be processed for those with the Intune Admin role over a device, however, the current implementation includes device ownership for processing. As device ownership already has its own edge (AZOwns), this edge is duplicative and unnecessary.

How Has This Been Tested?

New tests for foundational units that aid in the processing of AZExecuteCommand. More unit tests to follow in separate PR.

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

Copy link
Member

@computator computator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems reasonable afaict. I had two questions about things, but if they aren't concerns then it seems ready to merge to me!

@ddlees ddlees force-pushed the fix-azexecute-command branch from a5c9ce2 to 0213e96 Compare October 16, 2023 18:01
@ddlees ddlees merged commit fbec5ee into main Oct 18, 2023
@ddlees ddlees deleted the fix-azexecute-command branch October 18, 2023 19:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants