Skip to content

Conversation

@brandonshearin
Copy link
Contributor

@brandonshearin brandonshearin commented Oct 4, 2023

Description

This PR gives users the ability to save cypher queries to a list that can be found in the collapsible section underneath the cypher editor.

Two new components have been added to the shared library-- PrebuiltSearchList and SaveQueryInput. PrebuiltSearchList extracts the logic that was used to render the existing AD and Azure prebuilt queries into it's own component. This makes it easy to extend with a PersonalSearchList component, also in the shared folder.

The existing CommonSearches and CypherSearch components have small cleanups.

Three new endpoints have been added to the shared js-client-library to delete, create, and read user's saved queries.

Motivation and Context

How Has This Been Tested?

Unit tests have been added to cover new components and user flows

Screenshots (if appropriate):

New "Custom Searches" list via the Cypher Search tab

localhost_3000_ui_explore(1792 x 1120 MBP)

Saving a custom query

localhost_3000_ui_explore(1792 x 1120 MBP) (1)

Viewing list of saved custom queries

localhost_3000_ui_explore(1792 x 1120 MBP) (2)

Deleting a custom query

localhost_3000_ui_explore(1792 x 1120 MBP) (3)

Viewing list of multiple saved queries

localhost_3000_ui_explore(1792 x 1120 MBP) (4)

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@brandonshearin brandonshearin changed the title draft: user saved queries user saved queries Oct 8, 2023
@superlinkx
Copy link
Contributor

Once conflicts are resolved, I think we can do a final review of the code and get this in

@elikmiller elikmiller changed the title user saved queries User Saved Cypher Queries Oct 23, 2023
@brandonshearin brandonshearin merged commit 4df2fcb into main Oct 25, 2023
@brandonshearin brandonshearin deleted the BED-3220 branch October 25, 2023 21:59
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants