-
Notifications
You must be signed in to change notification settings - Fork 271
User Saved Cypher Queries #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Hound into user_saved_queries_post
elikmiller
reviewed
Oct 11, 2023
Contributor
|
Once conflicts are resolved, I think we can do a final review of the code and get this in |
elikmiller
approved these changes
Oct 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR gives users the ability to save cypher queries to a list that can be found in the collapsible section underneath the cypher editor.
Two new components have been added to the shared library--
PrebuiltSearchListandSaveQueryInput.PrebuiltSearchListextracts the logic that was used to render the existing AD and Azure prebuilt queries into it's own component. This makes it easy to extend with aPersonalSearchListcomponent, also in the shared folder.The existing
CommonSearchesandCypherSearchcomponents have small cleanups.Three new endpoints have been added to the shared js-client-library to delete, create, and read user's saved queries.
Motivation and Context
How Has This Been Tested?
Unit tests have been added to cover new components and user flows
Screenshots (if appropriate):
New "Custom Searches" list via the Cypher Search tab
Saving a custom query
Viewing list of saved custom queries
Deleting a custom query
Viewing list of multiple saved queries
Types of changes
Checklist: