-
Notifications
You must be signed in to change notification settings - Fork 271
Saved user cypher queries (GET) #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
993685d to
7fc9526
Compare
elikmiller
reviewed
Sep 20, 2023
Contributor
Contributor
Author
|
Fixed count bug @elikmiller :
|
Contributor
Author
elikmiller
reviewed
Sep 22, 2023
elikmiller
reviewed
Sep 22, 2023
Contributor
|
Other than the concern that the permission used doesn't quite fit the use case and the TODO being ambiguous, this all tests well. Validated the schema and usage against the ticket and everything checks out otherwise. |
superlinkx
reviewed
Sep 25, 2023
superlinkx
reviewed
Sep 25, 2023
f7e4903 to
15ddca6
Compare
superlinkx
approved these changes
Sep 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.





Description
This MR adds the ability for users to CRUD custom cypher queries that persist through server restarts (but not through cleared DBs). Access to these queries will be limited to self for now.
How Has This Been Tested?
Added unit tests for model, handler
Manual testing:
Set up a custom query in the database as follows

Then tried different combinations of params and verified that each one returns the expected response:
Types of changes
Checklist: