IBC chain state request: adding the code commitment and the genesis da height to the chain state module. (#490)

* Updating the chain state module with the code commitment and the initial da height

* Changelog

* Adding a getter for the genesis_da_height

* Removing fuzz

* Removing fuzz changes

* Fixing proof generation

* Adding aggregated_circuit_code_commitment

* Updating code commitment names to respect inner/outer conventions

* Changelog

* Merging with nighly

* Fixing celestia demo

* Fixing bench

Author: theochap

CHANGELOG.md

@@ -1,3 +1,5 @@
+- #490 Adds a `inner_code_commitment`, an `outer_code_commitment` and a `initial_da_height` field to the `ChainState` module. These fields should be initialized at genesis. Added getters for `genesis_da_height`, `outer_code_commitment` and `inner_code_commitment` in the `ChainState` module. Adapted the `demo-rollup` json configurations to use these fields. Added a new configuration folder for the stf tests that rely on `MockCodeCommitment` which have a different format from the `risc0` code commitments (32 bytes instead of 8). Modified the `AttesterIncentives` module to use the `inner_code_commitment` field from the `ChainState` module instead of the `commitment_to_allowed_challenger_method` field. Modified the `ProverIncentives` module to use the `outer_code_commitment` field from the `ChainState` module instead of the `commitment_of_allowed_verifier_method` field. 
+ 
 - #487 Introduces the `AuthenticatedTransactionData` structure. This is the transaction data that passed the authentication phase. And updates `Accounts::CallMessage` format. This is a breaking change for consumers of the SDK only if they send messages directly to the Accounts module.
 
 - #484 Adds a new `CodeCommitment` trait and applies it to the associated type of the ZKVM. The 

Cargo.lock

@@ -125,14 +125,12 @@ async fn main() -> Result<(), anyhow::Error> {
     >::new();
 
     let demo_genesis_config = {
-        let integration_test_conf_dir: &Path = "../test-data/genesis/integration-tests".as_ref();
-        let rt_params = create_genesis_config::<TestSpec, _>(&GenesisPaths::from_dir(
-            integration_test_conf_dir,
-        ))
-        .unwrap();
+        let stf_tests_conf_dir: &Path = "../test-data/genesis/stf-tests".as_ref();
+        let rt_params =
+            create_genesis_config::<TestSpec, _>(&GenesisPaths::from_dir(stf_tests_conf_dir))
+                .unwrap();
 
-        let chain_state =
-            read_json_file(integration_test_conf_dir.join("chain_state.json")).unwrap();
+        let chain_state = read_json_file(stf_tests_conf_dir.join("chain_state.json")).unwrap();
         let kernel_params = BasicKernelGenesisConfig { chain_state };
         GenesisParams {
             runtime: rt_params,

examples/demo-rollup/benches/node/rollup_coarse_measure.rs

@@ -33,7 +33,7 @@ pub(crate) fn create_storage_manager_for_tests(
 
 pub(crate) fn create_genesis_config_for_tests<Da: DaSpec>(
 ) -> GenesisParams<GenesisConfig<S, Da>, BasicKernelGenesisConfig<S, Da>> {
-    let integ_test_conf_dir: &Path = "../../test-data/genesis/integration-tests".as_ref();
+    let integ_test_conf_dir: &Path = "../../test-data/genesis/stf-tests".as_ref();
     let rt_params =
         create_genesis_config::<S, Da>(&GenesisPaths::from_dir(integ_test_conf_dir)).unwrap();
 

examples/demo-rollup/stf/src/tests/mod.rs

@@ -29,7 +29,7 @@ type DefaultSpec = sov_modules_api::default_spec::DefaultSpec<
 
 mod datagen;
 
-const DEFAULT_GENESIS_CONFIG_DIR: &str = "../test-data/genesis/benchmark";
+const DEFAULT_GENESIS_CONFIG_DIR: &str = "../test-data/genesis/integration-tests";
 
 type TestSTF<'a> = StfBlueprint<
     DefaultSpec,

examples/demo-rollup/tests/prover/mod.rs

@@ -3,5 +3,14 @@
     "secs": 0,
     "nanos": 0
   },
-  "initial_base_fee_per_gas": [0, 0]
+  "initial_base_fee_per_gas": [0, 0],
+  "inner_code_commitment": [
+    0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+    0, 0, 0, 0, 0, 0, 0
+  ],
+  "outer_code_commitment": [
+    0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+    0, 0, 0, 0, 0, 0, 0
+  ],
+  "genesis_da_height": 0
 }

examples/test-data/genesis/benchmark/chain_state.json

@@ -1,10 +1,6 @@
 {
   "proving_penalty": 10,
   "minimum_bond": 10,
-  "commitment_of_allowed_verifier_method": [
-    0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
-    0, 0, 0, 0, 0, 0, 0
-  ],
   "initial_provers": [
     ["sov1l6n2cku82yfqld30lanm2nfw43n2auc8clw7r5u5m6s7p8jrm4zqrr8r94", 10]
   ]

examples/test-data/genesis/benchmark/prover_incentives.json

@@ -3,5 +3,11 @@
     "secs": 0,
     "nanos": 0
   },
-  "initial_base_fee_per_gas": [0, 0]
+  "initial_base_fee_per_gas": [0, 0],
+  "inner_code_commitment": [0, 0, 0, 0, 0, 0, 0, 0],
+  "outer_code_commitment": [
+    0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+    0, 0, 0, 0, 0, 0, 0
+  ],
+  "genesis_da_height": 3
 }

examples/test-data/genesis/demo/celestia/chain_state.json

@@ -1,10 +1,6 @@
 {
   "proving_penalty": 10,
   "minimum_bond": 10,
-  "commitment_of_allowed_verifier_method": [
-    0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
-    0, 0, 0, 0, 0, 0, 0
-  ],
   "initial_provers": [
     ["sov1l6n2cku82yfqld30lanm2nfw43n2auc8clw7r5u5m6s7p8jrm4zqrr8r94", 10]
   ]

examples/test-data/genesis/demo/celestia/prover_incentives.json

@@ -3,5 +3,11 @@
     "secs": 0,
     "nanos": 0
   },
-  "initial_base_fee_per_gas": [0, 0]
+  "initial_base_fee_per_gas": [0, 0],
+  "inner_code_commitment": [0, 0, 0, 0, 0, 0, 0, 0],
+  "outer_code_commitment": [
+    0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+    0, 0, 0, 0, 0, 0, 0
+  ],
+  "genesis_da_height": 0
 }