Make MerkleTree Sync (#38)

zvolin · web-flow · commit ebcc7cef3540 · 2025-06-11T10:54:35.000+01:00
* Make MerkleTree Sync

* Bump version to 0.2.5

Signed-off-by: Maciej Zwoliński &lt;mac.zwolinski@gmail.com&gt;
diff --git a/Cargo.toml b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "nmt-rs"
-version = "0.2.4"
+version = "0.2.5"
 edition = "2021"
 description = "A namespaced merkle tree compatible with Celestia"
 license = "MIT OR Apache-2.0"
diff --git a/src/lib.rs b/src/lib.rs
@@ -843,4 +843,11 @@ mod tests {
 
         is_send(DefaultNmt::<1>::new());
     }
+
+    #[allow(unused)]
+    fn compilation_test_nmt_is_sync() {
+        fn is_sync<T: Sync>(_t: T) {}
+
+        is_sync(DefaultNmt::<1>::new());
+    }
 }
diff --git a/src/simple_merkle/tree.rs b/src/simple_merkle/tree.rs
@@ -30,7 +30,7 @@ impl<T> TakeFirst<T> for [T] {
     }
 }
 
-type BoxedVisitor<M> = Box<dyn Fn(&<M as MerkleHash>::Output) + Send>;
+type BoxedVisitor<M> = Box<dyn Fn(&<M as MerkleHash>::Output) + Send + Sync>;
 
 /// Helper data structure for immutable data used during proof narrowing recursion.
 /// All indices are relative to the leaves of the entire tree.

Original file line number	Diff line number	Diff line change
`@@ -843,4 +843,11 @@ mod tests {`
`843`	`843`
`844`	`844`	`is_send(DefaultNmt::<1>::new());`
`845`	`845`	`}`
	`846`	`+`
	`847`	`+ #[allow(unused)]`
	`848`	`+ fn compilation_test_nmt_is_sync() {`
	`849`	`+ fn is_sync<T: Sync>(_t: T) {}`
	`850`	`+`
	`851`	`+ is_sync(DefaultNmt::<1>::new());`
	`852`	`+ }`
`846`	`853`	`}`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ impl<T> TakeFirst<T> for [T] {`
`30`	`30`	`}`
`31`	`31`	`}`
`32`	`32`
`33`		`-type BoxedVisitor<M> = Box<dyn Fn(&<M as MerkleHash>::Output) + Send>;`
	`33`	`+type BoxedVisitor<M> = Box<dyn Fn(&<M as MerkleHash>::Output) + Send + Sync>;`
`34`	`34`
`35`	`35`	`/// Helper data structure for immutable data used during proof narrowing recursion.`
`36`	`36`	`/// All indices are relative to the leaves of the entire tree.`