Skip to content

Commit 2f06155

Browse files
JS-523 Remove queries and assertions on non-persisted metrics (#5052)
1 parent c7f5058 commit 2f06155

File tree

2 files changed

+0
-91
lines changed

2 files changed

+0
-91
lines changed

its/plugin/tests/src/test/java/com/sonar/javascript/it/plugin/CssMetricsTest.java

Lines changed: 0 additions & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -45,77 +45,5 @@ void test() {
4545
"css=27;php=1;web=24"
4646
);
4747
assertThat(getMeasureAsDouble(PROJECT_KEY, "comment_lines")).isEqualTo(6);
48-
49-
assertThat(getMeasure(PROJECT_KEY + ":src/file1.css", "ncloc_data").getValue()).contains(
50-
"1=1;",
51-
"2=1;",
52-
"3=1;",
53-
"4=1;",
54-
"5=1;",
55-
"6=1;",
56-
"7=1"
57-
);
58-
59-
assertThat(getMeasure(PROJECT_KEY + ":src/file2.less", "ncloc_data").getValue()).contains(
60-
"1=1;",
61-
"2=1;",
62-
"3=1;",
63-
"4=1;",
64-
"5=1;",
65-
"6=1;",
66-
"7=1;",
67-
"8=1;",
68-
"9=1"
69-
);
70-
71-
assertThat(getMeasure(PROJECT_KEY + ":src/file3.scss", "ncloc_data").getValue()).contains(
72-
"1=1;",
73-
"3=1;",
74-
"5=1;",
75-
"6=1;",
76-
"7=1;",
77-
"8=1"
78-
);
79-
80-
assertThat(getMeasure(PROJECT_KEY + ":src/file4.sass", "ncloc_data").getValue()).contains(
81-
"1=1",
82-
"3=1",
83-
"5=1",
84-
"6=1",
85-
"7=1"
86-
);
87-
88-
assertThat(getMeasure(PROJECT_KEY + ":src/file5.html", "ncloc_data").getValue()).contains(
89-
"1=1",
90-
"2=1",
91-
"3=1",
92-
"4=1",
93-
"5=1",
94-
"6=1",
95-
"7=1",
96-
"8=1",
97-
"9=1",
98-
"10=1"
99-
);
100-
101-
// .htm is not part of sonar-HTML languages. When it is, an assertion should be added for file6.htm
102-
// https://sonarsource.atlassian.net/jira/software/c/projects/SONARHTML/issues/SONARHTML-180
103-
104-
assertThat(getMeasure(PROJECT_KEY + ":src/file7.xhtml", "ncloc_data").getValue()).contains(
105-
"1=1",
106-
"2=1",
107-
"4=1",
108-
"5=1",
109-
"6=1",
110-
"7=1",
111-
"8=1",
112-
"9=1",
113-
"10=1",
114-
"11=1",
115-
"12=1",
116-
"13=1",
117-
"14=1",
118-
"15=1"
119-
);
12048
}
12149
}

its/plugin/tests/src/test/java/com/sonar/javascript/it/plugin/MetricsTest.java

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -109,25 +109,6 @@ void file_level() {
109109
assertThat(getFileMeasureAsDouble("violations")).isZero();
110110
}
111111

112-
/**
113-
* SONARPLUGINS-2183
114-
*/
115-
@Test
116-
void should_be_compatible_with_DevCockpit() {
117-
// 2 header comment line
118-
// 4 empty line
119-
// 5 code line
120-
// 14 comment line
121-
// 15 empty comment line
122-
123-
assertThat(getFileMeasure("ncloc_data").getValue())
124-
.doesNotContain(";2=1;")
125-
.doesNotContain(";4=1;")
126-
.contains("5=1;")
127-
.doesNotContain(";14=1;")
128-
.doesNotContain(";15=1;");
129-
}
130-
131112
/* Helper methods */
132113

133114
private Double getProjectMeasureAsDouble(String metricKey) {

0 commit comments

Comments
 (0)