Skip to content

Commit 1d8d51d

Browse files
authored
Add missing argument to OSSHandler's _format_prompt function (#373)
# Overview In this PR, I added a missing argument to `OSSHandler`'s `_format_prompt` function. Also my code formatter sorted the imports alphabetically which accounts for all the other changes, including those in `handler_map.py`. # What Happened? In every model handler, we define `_format_prompt` as taking in three arguments (`prompt`, `function`, `test_category`). This is the standard. But in `OSSHandler`, `_format_prompt` is defined as only taking in `prompt` and `function` and forgetting to take `test_category` as an input. This caused an error. So I simply added `test_category` to the definition of `_format_prompt`.
1 parent 9bb8bb0 commit 1d8d51d

File tree

2 files changed

+16
-11
lines changed

2 files changed

+16
-11
lines changed

berkeley-function-call-leaderboard/model_handler/handler_map.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
1-
from model_handler.gorilla_handler import GorillaHandler
2-
from model_handler.gpt_handler import OpenAIHandler
31
from model_handler.claude_fc_handler import ClaudeFCHandler
42
from model_handler.claude_prompt_handler import ClaudePromptingHandler
5-
from model_handler.mistral_handler import MistralHandler
3+
from model_handler.databricks_handler import DatabricksHandler
4+
from model_handler.deepseek_handler import DeepseekHandler
65
from model_handler.firework_ai_handler import FireworkAIHandler
7-
from model_handler.nexus_handler import NexusHandler
6+
from model_handler.functionary_handler import FunctionaryHandler
87
from model_handler.gemini_handler import GeminiHandler
9-
from model_handler.oss_handler import OSSHandler
108
from model_handler.gemma_handler import GemmaHandler
119
from model_handler.glaive_handler import GlaiveHandler
12-
from model_handler.deepseek_handler import DeepseekHandler
13-
from model_handler.functionary_handler import FunctionaryHandler
14-
from model_handler.databricks_handler import DatabricksHandler
10+
from model_handler.gorilla_handler import GorillaHandler
11+
from model_handler.gpt_handler import OpenAIHandler
1512
from model_handler.hermes_handler import HermesHandler
13+
from model_handler.mistral_handler import MistralHandler
14+
from model_handler.nexus_handler import NexusHandler
15+
from model_handler.oss_handler import OSSHandler
1616

1717
handler_map = {
1818
"gorilla-openfunctions-v0": GorillaHandler,

berkeley-function-call-leaderboard/model_handler/oss_handler.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,17 @@
1+
import json
2+
import os
3+
4+
import ray
5+
import shortuuid
6+
import torch
7+
from eval_checker.eval_runner_constant import FILENAME_INDEX_MAPPING
18
from model_handler.handler import BaseHandler
29
from model_handler.model_style import ModelStyle
310
from model_handler.utils import (
411
ast_parse,
512
augment_prompt_by_languge,
613
language_specific_pre_processing,
714
)
8-
from eval_checker.eval_runner_constant import FILENAME_INDEX_MAPPING
9-
import shortuuid, ray, os, json, torch
1015

1116

1217
class OSSHandler(BaseHandler):
@@ -18,7 +23,7 @@ def __init__(self, model_name, temperature=0.7, top_p=1, max_tokens=1000) -> Non
1823
def _init_model(self):
1924
ray.init(ignore_reinit_error=True, num_cpus=8)
2025

21-
def _format_prompt(prompt, function):
26+
def _format_prompt(prompt, function, test_category):
2227
SYSTEM_PROMPT = """
2328
You are an helpful assistant who has access to the following functions to help the user, you can use the functions if needed-
2429
"""

0 commit comments

Comments
 (0)