feat(charts): adding labels and annotations to a seldonconfig component #5918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lc525
reviewed
Sep 18, 2024
lc525
reviewed
Sep 20, 2024
driev
commented
Sep 23, 2024
lc525
reviewed
Sep 24, 2024
lc525
reviewed
Sep 24, 2024
driev
changed the title
jtayl222
pushed a commit
to jtayl222/seldon-core
that referenced
this pull request
Jul 20, 2025
…donIO#5918) * adding a metadata object to seldonconfig components * adding labels to the servers helm charts * add metadata to seldonconfig.component * using sed to template the templates * add makefile changes * patching each component with labels and annotations * add a test * missing forward slash * hack labelz * remove test labels * add annotationz to servers * add prometheus annotations to the default seldonconfig * add a comment and a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This allows for granular customisations, which are described in #5185
Which issue(s) this PR fixes:
Fixes #5185
INFRA-642
Special notes for your reviewer: