#89 코드 리팩토링 추가

Author: kidonge

nodejs-frontend/static/js/roomlist/roomlist.js

@@ -65,10 +65,9 @@ const roomList = {
     });
 
     eventSource.addEventListener('roomDeleted', function(event) {
-      const deletedRoom = JSON.parse(event.data);
-      const deletedRoomId = deletedRoom.roomId;
+      const { roomId } = JSON.parse(event.data);
       $('#roomTableBody')
-          .find(`[data-id='${deletedRoomId}'], [data-roomid='${deletedRoomId}']`)
+          .find(`[data-id='${roomId}'], [data-roomid='${roomId}']`)
           .closest('tr')
           .remove();
     });
@@ -78,30 +77,23 @@ const roomList = {
     });
 
     eventSource.addEventListener("changeUserCnt", function (event) {
-      const chatRoom = JSON.parse(event.data);
-      const chatRoomId = chatRoom.roomId;
-      const userCnt = chatRoom.userCount;
-      const {maxUserCnt} = chatRoom;
+      const { roomId, userCount, maxUserCnt } = JSON.parse(event.data);
 
       const $row = $('#roomTableBody')
-          .find(`[data-id='${chatRoomId}'], [data-roomid='${chatRoomId}']`)
+          .find(`[data-id='${roomId}'], [data-roomid='${roomId}']`)
           .closest('tr');
 
-      $row.find('span.room-user-count').text(`${userCnt}/${maxUserCnt}`);
+      $row.find('span.room-user-count').text(`${userCount}/${maxUserCnt}`);
     });
 
     eventSource.addEventListener("changeRoomSetting", function (event) {
-      const chatRoom = JSON.parse(event.data);
-      const chatRoomId = chatRoom.roomId;
-      const roomName = chatRoom.roomName;
-      const userCnt = chatRoom.userCount;
-      const maxUserCnt = chatRoom.maxUserCnt;
+      const { roomId, roomName, userCount, maxUserCnt } = JSON.parse(event.data);
 
       const $row = $('#roomTableBody')
-          .find(`[data-id='${chatRoomId}'], [data-roomid='${chatRoomId}']`)
+          .find(`[data-id='${roomId}'], [data-roomid='${roomId}']`)
           .closest('tr');
 
-      $row.find('span.room-user-count').text(`${userCnt}/${maxUserCnt}`);
+      $row.find('span.room-user-count').text(`${userCount}/${maxUserCnt}`);
       $row.find('.enterRoomBtn, .directEnterBtn').text(roomName);
     });
 

springboot-backend/src/main/java/webChat/service/chatroom/SseService.java

@@ -6,6 +6,7 @@
 import webChat.model.room.ChatRoom;
 
 import java.io.IOException;
+import java.util.ArrayList;
 import java.util.List;
 import java.util.concurrent.CopyOnWriteArrayList;
 
@@ -31,7 +32,7 @@ public SseEmitter createEmitter() {
 
     // 방 생성 시, 연결된 모든 클라이언트에게 이벤트 전송
     public void sendRoomCreatedEvent(ChatRoom room) {
-        List<SseEmitter> deadEmitters = new CopyOnWriteArrayList<>();
+        List<SseEmitter> deadEmitters = new ArrayList<>();
 
         for (SseEmitter emitter : emitters) {
             try {
@@ -48,7 +49,7 @@ public void sendRoomCreatedEvent(ChatRoom room) {
 
     // 방 삭제 시 이벤트 전송
     public void sendRoomDeletedEvent(ChatRoom room) {
-        List<SseEmitter> deadEmitters = new CopyOnWriteArrayList<>();
+        List<SseEmitter> deadEmitters = new ArrayList<>();
 
         for (SseEmitter emitter : emitters) {
             try {
@@ -67,7 +68,7 @@ public void sendRoomDeletedEvent(ChatRoom room) {
     // 핑 관련 이벤트 전송
     @Scheduled(fixedDelay = 10_000L * 7) // 7분
     public void sendPingToClients() {
-        List<SseEmitter> deadEmitters = new CopyOnWriteArrayList<>();
+        List<SseEmitter> deadEmitters = new ArrayList<>();
         for (SseEmitter emitter : emitters) {
             try {
                 emitter.send(SseEmitter.event()
@@ -82,7 +83,7 @@ public void sendPingToClients() {
 
     // 방 인원수 변경 시 이벤트 전송
     public void sendRoomUserCntEvent(ChatRoom room) {
-        List<SseEmitter> deadEmitters = new CopyOnWriteArrayList<>();
+        List<SseEmitter> deadEmitters = new ArrayList<>();
 
         for (SseEmitter emitter : emitters) {
             try {
@@ -97,7 +98,7 @@ public void sendRoomUserCntEvent(ChatRoom room) {
     }
 
     public void sendChangeRoomSettingEvent(ChatRoom room) {
-        List<SseEmitter> deadEmitters = new CopyOnWriteArrayList<>();
+        List<SseEmitter> deadEmitters = new ArrayList<>();
 
         for (SseEmitter emitter : emitters) {
             try {