Skip to content

Commit 6ce04b8

Browse files
committed
#67 로그인 관련 에러처리 로직 추가
1 parent 3761a67 commit 6ce04b8

File tree

4 files changed

+9
-10
lines changed

4 files changed

+9
-10
lines changed

springboot-backend/src/main/java/webChat/service/login/LoginService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
public interface LoginService {
99
void logout(String authorization, String email) throws Exception;
10-
GoogleOAuth checkSocialUser(String accessToken, String refreshToken, String name, String email, boolean emailVerified, String photo);
10+
GoogleOAuth checkSocialUser(String accessToken, String refreshToken, String name, String email, boolean emailVerified, String photo) throws BadRequestException;
1111
QRLoginResponse createQRSession();
1212
GoogleOAuth authenticateQRSession(String sessionId, @NonNull String accessToken, @NonNull String refreshToken, @NonNull String name, @NonNull String email, boolean emailVerified, String photo) throws BadRequestException;
1313
QRLoginResponse getSessionStatus(String sessionId) throws BadRequestException;

springboot-backend/src/main/java/webChat/service/login/impl/LoginServiceImpl.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ public class LoginServiceImpl implements LoginService {
4343

4444
@Transactional
4545
@Override
46-
public GoogleOAuth checkSocialUser(@NonNull String accessToken, @NonNull String refreshToken, @NonNull String name, @NonNull String email, boolean emailVerified, String photo) {
46+
public GoogleOAuth checkSocialUser(@NonNull String accessToken, @NonNull String refreshToken, @NonNull String name, @NonNull String email, boolean emailVerified, String photo) throws BadRequestException {
4747
if (!emailVerified) {
48-
// TODO 예외처리?? :: googleOAuth.isEmailVerified() 값이 정확히 뭔지 모르겠어요ㅠㅠ
48+
throw new BadRequestException("This email is not verified !!!");
4949
}
5050

5151
SocialUser socialUser = socialUserRepository.findByEmail(email);
@@ -58,9 +58,7 @@ public GoogleOAuth checkSocialUser(@NonNull String accessToken, @NonNull String
5858
}
5959

6060
if(decodeToken == null || !decodeToken.isEmailVerified()){
61-
// TODO 예외처리??
62-
log.error("google decodeToken 토큰 검증 처리 실패 !!!");
63-
return null;
61+
throw new BadRequestException("This account is not verified.");
6462
}
6563

6664
// 계정이 없는 경우

springboot-backend/src/main/java/webChat/service/user/UserService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@
44
import webChat.model.user.UserDto;
55

66
public interface UserService {
7-
UserDto getUserInfo(OauthRedis oauthRedis);
7+
UserDto getUserInfo(OauthRedis oauthRedis) throws Exception;
88
}

springboot-backend/src/main/java/webChat/service/user/impl/UserServiceImpl.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import lombok.RequiredArgsConstructor;
44
import lombok.extern.slf4j.Slf4j;
5+
import org.apache.coyote.BadRequestException;
56
import org.springframework.stereotype.Service;
67
import webChat.entity.SocialUser;
78
import webChat.model.login.OauthRedis;
@@ -18,11 +19,11 @@ public class UserServiceImpl implements UserService {
1819
private final SocialUserRepository socialUserRepository;
1920

2021
@Override
21-
public UserDto getUserInfo(OauthRedis oauthRedis) {
22+
public UserDto getUserInfo(OauthRedis oauthRedis) throws Exception {
2223
Optional<SocialUser> socialUser = Optional.ofNullable(socialUserRepository.findByEmail(oauthRedis.getEmail()));
2324

24-
if(socialUser.isEmpty()){
25-
// TODO 예외처리
25+
if(socialUser == null || socialUser.isEmpty()){
26+
throw new BadRequestException("Not exist user !!!");
2627
}
2728

2829
return UserDto.of(socialUser.get(), oauthRedis);

0 commit comments

Comments
 (0)