Optimize FixedPoint::sqrt() signedness check

bytegrrrl · heinezen · heinezen · commit 292d6dadd5ec · 2025-04-24T00:49:40.000+02:00
Co-authored-by: Christoph Heine &lt;6852422+heinezen@users.noreply.github.com&gt;
diff --git a/libopenage/util/fixed_point.h b/libopenage/util/fixed_point.h
@@ -464,7 +464,9 @@ class FixedPoint {
 		}
 
 		// Check for negative values
-		ENSURE(std::is_unsigned<raw_type>() or (std::is_signed<raw_type>() and this->raw_value > 0), "FixedPoint::sqrt() is undefined for negative values.");
+		if constexpr (std::is_signed<raw_type>()) {
+			ENSURE(this->raw_value > 0, "FixedPoint::sqrt() is undefined for negative values.");
+		}
 
 		// A greater shift = more precision, but can overflow the intermediate type if too large.
 		size_t max_shift = std::countl_zero(static_cast<unsigned_intermediate_type>(this->raw_value)) - 1;

Original file line number	Diff line number	Diff line change
`@@ -464,7 +464,9 @@ class FixedPoint {`
`464`	`464`	`}`
`465`	`465`
`466`	`466`	`// Check for negative values`
`467`		`- ENSURE(std::is_unsigned<raw_type>() or (std::is_signed<raw_type>() and this->raw_value > 0), "FixedPoint::sqrt() is undefined for negative values.");`
	`467`	`+ if constexpr (std::is_signed<raw_type>()) {`
	`468`	`+ ENSURE(this->raw_value > 0, "FixedPoint::sqrt() is undefined for negative values.");`
	`469`	`+ }`
`468`	`470`
`469`	`471`	`// A greater shift = more precision, but can overflow the intermediate type if too large.`
`470`	`472`	`size_t max_shift = std::countl_zero(static_cast<unsigned_intermediate_type>(this->raw_value)) - 1;`