#1861 fixed out of bounds access

Robosturm · Robosturm · commit 6745490e7282 · 2025-01-09T19:07:11.000+01:00
diff --git a/game/player.cpp b/game/player.cpp
@@ -1944,7 +1944,7 @@ QPoint Player::getRockettarget(qint32 radius, qint32 damage, qreal ownUnitValue,
         }
     }
 
-    if (targets.size() >= 0)
+    if (targets.size() > 0)
     {
         return targets[GlobalUtils::randInt(0, targets.size() - 1)];
     }
@@ -1999,7 +1999,7 @@ QPoint Player::getSiloRockettarget(qint32 radius, qint32 damage, qint32 & highes
             }
         }
     }
-    if (targets.size() >= 0)
+    if (targets.size() > 0)
     {
         return targets[GlobalUtils::randInt(0, targets.size() - 1)];
     }

Original file line number	Diff line number	Diff line change
`@@ -1944,7 +1944,7 @@ QPoint Player::getRockettarget(qint32 radius, qint32 damage, qreal ownUnitValue,`
`1944`	`1944`	`}`
`1945`	`1945`	`}`
`1946`	`1946`
`1947`		`- if (targets.size() >= 0)`
	`1947`	`+ if (targets.size() > 0)`
`1948`	`1948`	`{`
`1949`	`1949`	`return targets[GlobalUtils::randInt(0, targets.size() - 1)];`
`1950`	`1950`	`}`
`@@ -1999,7 +1999,7 @@ QPoint Player::getSiloRockettarget(qint32 radius, qint32 damage, qint32 & highes`
`1999`	`1999`	`}`
`2000`	`2000`	`}`
`2001`	`2001`	`}`
`2002`		`- if (targets.size() >= 0)`
	`2002`	`+ if (targets.size() > 0)`
`2003`	`2003`	`{`
`2004`	`2004`	`return targets[GlobalUtils::randInt(0, targets.size() - 1)];`
`2005`	`2005`	`}`