Skip to content

Conversation

@badasahog
Copy link
Contributor

This should improve speed and readability

@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.11%. Comparing base (8d0faee) to head (adac865).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7368   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files          85       85           
  Lines       16449    16449           
=======================================
  Hits        16304    16304           
  Misses        145      145           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ben-schwen
Copy link
Member

Overall LGTM, some minor tweaks needed. AFAIU R internals the read only variants will not be faster or only in subtle cases like ALTREP.

@jangorecki
Copy link
Member

If something is meant to be faster it is always good to include a benchmark, even the most optimistic one, of before vs after

@ben-schwen ben-schwen merged commit 9920cbc into master Oct 18, 2025
11 of 12 checks passed
@ben-schwen ben-schwen deleted the ReadOnlyImprovements branch October 18, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants