-
Notifications
You must be signed in to change notification settings - Fork 1k
Changed many function calls to use read only variants when appropriate #7368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7368 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 85 85
Lines 16449 16449
=======================================
Hits 16304 16304
Misses 145 145 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Overall LGTM, some minor tweaks needed. AFAIU R internals the read only variants will not be faster or only in subtle cases like |
|
If something is meant to be faster it is always good to include a benchmark, even the most optimistic one, of before vs after |
This should improve speed and readability