Skip to content

revdep heatwaveR example failure after frollapply argument name change #7295

@tdhock

Description

@tdhock

#7272 causes a new example failure in heatwaveR https://rcdata.nau.edu/genomic-ml/data.table-revdeps/analyze/2025-09-08/heatwaveR.txt

-* checking examples ... OK
+* checking examples ... ERROR
+Running examples in 'heatwaveR-Ex.R' failed
+The error most likely occurred in:
+
+> base::assign(".ptime", proc.time(), pos = "CheckExEnv")
+> ### Name: ts2clm3
+> ### Title: Make a climatology from a daily time series.
+> ### Aliases: ts2clm3
+> 
+> ### ** Examples
+> 
+> data.table::setDTthreads(threads = 1) # optimise for your code and local computer
+> res <- ts2clm3(sst_WA, climatologyPeriod = c("1983-01-01", "2012-12-31"))
+> res[1:10, ]
+             t  temp    seas  thresh
+        <Date> <num>   <num>   <num>
+ 1: 1982-01-01 20.94 21.6080 22.9605
+ 2: 1982-01-02 21.25 21.6348 22.9987
+ 3: 1982-01-03 21.38 21.6621 23.0376
+ 4: 1982-01-04 21.16 21.6895 23.0771
+ 5: 1982-01-05 21.26 21.7169 23.1130
+ 6: 1982-01-06 21.61 21.7436 23.1460
+ 7: 1982-01-07 21.74 21.7699 23.1775
+ 8: 1982-01-08 21.50 21.7958 23.2080
+ 9: 1982-01-09 21.40 21.8217 23.2366
+10: 1982-01-10 21.36 21.8478 23.2649
+> 
+> # Or if one only wants the 366 day climatology
+> res_clim <- ts2clm3(sst_WA, climatologyPeriod = c("1983-01-01", "2012-12-31"),
++                     clmOnly = TRUE)
+> res_clim[1:10, ]
+      doy    seas  thresh
+    <num>   <num>   <num>
+ 1:     1 21.6080 22.9605
+ 2:     2 21.6348 22.9987
+ 3:     3 21.6621 23.0376
+ 4:     4 21.6895 23.0771
+ 5:     5 21.7169 23.1130
+ 6:     6 21.7436 23.1460
+ 7:     7 21.7699 23.1775
+ 8:     8 21.7958 23.2080
+ 9:     9 21.8217 23.2366
+10:    10 21.8478 23.2649
+> 
+> # Or if one wants the variance column included in the results
+> res_var <- ts2clm3(sst_WA, climatologyPeriod = c("1983-01-01", "2012-12-31"),
++                    var = TRUE)
+Warning in data.table::frollapply(thresh, n = smoothPercentileWidth, var,  :
+  'n' is deprecated in frollapply, use 'N' instead
+Error in data.table::frollapply(thresh, n = smoothPercentileWidth, var,  : 
+  argument "FUN" is missing, with no default
+Calls: ts2clm3 ... [.data.table -> eval -> eval -> <Anonymous> -> match.fun
+Execution halted
 * checking for unstated dependencies in 'tests' ... OK
 * checking tests ... OK
   Running 'testthat.R'
@@ -72,4 +124,4 @@
 * checking re-building of vignette outputs ... OK
 * checking PDF version of manual ... OK
 * DONE
-Status: OK
+Status: 1 ERROR

@jangorecki can you please investigate?

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions