feat: added terminal_cmd to config, if set, exec in terminal and not a buffer (#534)

Author: mbwilding

README.md

@@ -239,6 +239,7 @@ For overriding the default mappings when using `lazy.nvim` [check out our wiki p
     bin = "kubediff" -- or any other binary
   },
   kubectl_cmd = { cmd = "kubectl", env = {}, args = {}, persist_context_change = false },
+  terminal_cmd = nil, -- Exec will launch in a terminal if set, i.e. "ghostty -e"
   namespace = "All",
   namespace_fallback = {}, -- If you have limited access you can list all the namespaces here
   hints = true,

lua/kubectl/config.lua

@@ -3,6 +3,7 @@ local M = {}
 ---@class KubectlOptions
 ---@field log_level number
 ---@field auto_refresh { enabled: boolean, interval: number }
+---@field terminal_cmd string?
 ---@field namespace string
 ---@field namespace_fallback string[]
 ---@field headers boolean
@@ -29,6 +30,7 @@ local defaults = {
   -- NOTE: Some executions using the io.open and vim.fn.terminal will still have default shell environments,
   -- in that case, the environments below will not override the defaults and should not be in your .zshrc/.bashrc files
   kubectl_cmd = { cmd = "kubectl", env = {}, args = {}, persist_context_change = false },
+  terminal_cmd = nil, -- Exec will launch in a terminal if set, i.e. "ghostty -e"
   namespace = "All",
   namespace_fallback = {},
   headers = true,

lua/kubectl/views/containers/init.lua

@@ -22,8 +22,16 @@ function M.View(pod, ns)
 end
 
 function M.exec(pod, ns)
-  buffers.floating_buffer("k8s_container_exec", "ssh " .. M.selection)
-  commands.execute_terminal("kubectl", { "exec", "-it", pod, "-n", ns, "-c ", M.selection, "--", "/bin/sh" })
+  local args = { "exec", "-it", pod, "-n", ns, "-c ", M.selection, "--", "/bin/sh" }
+  local cmd = "kubectl"
+
+  if config.options.terminal_cmd then
+    local command = commands.configure_command(cmd, {}, args)
+    vim.fn.jobstart(config.options.terminal_cmd .. " " .. table.concat(command.args, " "))
+  else
+    buffers.floating_buffer("k8s_container_exec", "ssh " .. M.selection)
+    commands.execute_terminal(cmd, args)
+  end
 end
 
 function M.debug(pod, ns)