Skip to content

Commit c4d3553

Browse files
[release/2.4] Use rocm6.2 aotriton shared library tarball and reduce min gcc version to 9.2 (#1537)
Tested via http://rocm-ci.amd.com/job/rocm-pytorch-manylinux-wheel-builder/554/
1 parent bf5d809 commit c4d3553

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

.ci/docker/aotriton_version.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
0.6b
22
manylinux_2_17
3-
rocm6
3+
rocm6.2
44
04b5df8c8123f90cba3ede7e971e6fbc6040d506
5-
3db6ecbc915893ff967abd6e1b43bd5f54949868873be60dc802086c3863e648
5+
e4ab195d2bd19e939c675a13280c29714c6ef9f2cf420690da150fa0cac043b1

CMakeLists.txt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,14 +54,15 @@ set(CMAKE_C_STANDARD
5454
# ---[ Utils
5555
include(cmake/public/utils.cmake)
5656

57-
# --- [ Check that minimal gcc version is 9.3+
58-
if(CMAKE_COMPILER_IS_GNUCXX AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 9.3)
57+
# --- [ Check that minimal gcc version is 9.2+
58+
if(CMAKE_COMPILER_IS_GNUCXX AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 9.2)
5959
message(
6060
FATAL_ERROR
61-
"GCC-9.3 or newer is required to compile PyTorch, but found ${CMAKE_CXX_COMPILER_VERSION}"
61+
"GCC-9.2 or newer is required to compile PyTorch, but found ${CMAKE_CXX_COMPILER_VERSION}"
6262
)
6363
endif()
6464

65+
6566
# This define is needed to preserve behavior given anticpated changes to
6667
# cccl/thrust
6768
# https://nvidia.github.io/libcudacxx/standard_api/numerics_library/complex.html

cmake/External/aotriton.cmake

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@ if(NOT __AOTRITON_INCLUDED)
2222
-DAOTRITON_COMPRESS_KERNEL=OFF
2323
-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
2424
-DAOTRITON_NO_PYTHON=ON
25-
-DAOTRITON_NO_SHARED=ON
25+
-DAOTRITON_NO_SHARED=OFF
2626
# CONFIGURE_COMMAND ""
2727
BUILD_COMMAND "" # No build, install command will repeat the build process due to problems in the build system.
28-
BUILD_BYPRODUCTS "${__AOTRITON_INSTALL_DIR}/lib/libaotriton_v2.a"
28+
BUILD_BYPRODUCTS "${__AOTRITON_INSTALL_DIR}/lib/libaotriton_v2.so"
2929
USES_TERMINAL_DOWNLOAD TRUE
3030
USES_TERMINAL_CONFIGURE TRUE
3131
USES_TERMINAL_BUILD TRUE
@@ -35,7 +35,7 @@ if(NOT __AOTRITON_INCLUDED)
3535
add_dependencies(__caffe2_aotriton aotriton_external)
3636
message(STATUS "Using AOTriton compiled from source directory ${__AOTRITON_SOURCE_DIR}")
3737
endif()
38-
target_link_libraries(__caffe2_aotriton INTERFACE ${__AOTRITON_INSTALL_DIR}/lib/libaotriton_v2.a)
38+
target_link_libraries(__caffe2_aotriton INTERFACE ${__AOTRITON_INSTALL_DIR}/lib/libaotriton_v2.so)
3939
target_include_directories(__caffe2_aotriton INTERFACE ${__AOTRITON_INSTALL_DIR}/include)
4040
set(AOTRITON_FOUND TRUE)
4141
endif() # __AOTRITON_INCLUDED

0 commit comments

Comments
 (0)