Skip to content

Commit 73d5920

Browse files
added bidirectional condition back as they are passing
1 parent 7cb0db7 commit 73d5920

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tests/experimental_rnn_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ class RnnTest(jtu.JaxTestCase):
3939
def test_lstm(self, batch_size: int, seq_len: int, input_size: int,
4040
hidden_size: int, num_layers: int, bidirectional: bool):
4141
# TODO(ruturaj4): Bidirectional doesn't quite work well with rocm.
42-
if jtu.is_device_rocm:
43-
self.skipTest("Skip on ROCm: test_lstm")
42+
if bidirectional and jtu.is_device_rocm():
43+
self.skipTest("Skip on ROCm: tests/experimental_rnn_test.py::RnnTest::test_lstm: Bidirectional mode is not available for ROCm.")
4444

4545
num_directions = 2 if bidirectional else 1
4646
seq_length_key, root_key = jax.random.split(jax.random.PRNGKey(0))

0 commit comments

Comments
 (0)