Skip to content

Commit 641895e

Browse files
authored
fix: fully disable the canned ACL during bucket creation (#52)
1 parent 92a6613 commit 641895e

File tree

2 files changed

+0
-10
lines changed

2 files changed

+0
-10
lines changed

config/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@
6363
| [aws_route53_record.smtp_mail_from_txt](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/route53_record) | resource |
6464
| [aws_route53_record.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/route53_record) | resource |
6565
| [aws_s3_bucket.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket) | resource |
66-
| [aws_s3_bucket_acl.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_acl) | resource |
6766
| [aws_s3_bucket_ownership_controls.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_ownership_controls) | resource |
6867
| [aws_s3_bucket_server_side_encryption_configuration.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_server_side_encryption_configuration) | resource |
6968
| [aws_secretsmanager_secret.dockerhub_credentials](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/secretsmanager_secret) | resource |

config/s3.tf

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,6 @@ resource "aws_s3_bucket_ownership_controls" "this" {
1919
depends_on = [aws_s3_bucket.this]
2020
}
2121

22-
resource "aws_s3_bucket_acl" "this" {
23-
for_each = { for k, v in local.s3_bucket_names : k => v if var.enable_s3 }
24-
25-
bucket = aws_s3_bucket.this[each.key].id
26-
acl = "private"
27-
28-
depends_on = [aws_s3_bucket_ownership_controls.this]
29-
}
30-
3122
resource "aws_s3_bucket_server_side_encryption_configuration" "this" {
3223
for_each = { for k, v in local.s3_bucket_names : k => v if var.enable_s3 }
3324

0 commit comments

Comments
 (0)