Skip to content

Commit 0771ee9

Browse files
Fix typos and small bugs
1 parent 207b7e2 commit 0771ee9

File tree

6 files changed

+10
-10
lines changed

6 files changed

+10
-10
lines changed

.vscode/settings.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@
144144
"moonrakerapirouter",
145145
"moonrakerclient",
146146
"moonrakercommandhandler",
147-
"moonrakercredentailmanager",
147+
"moonrakercredentialmanager",
148148
"moonrakerdatabase",
149149
"moonrakerhost",
150150
"moonrakerwebcamhelper",

moonraker_octoeverywhere/moonrakerclient.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
from linux_host.config import Config
2323

2424
from .filemetadatacache import FileMetadataCache
25-
from .moonrakercredentailmanager import MoonrakerCredentialManager
25+
from .moonrakercredentialmanager import MoonrakerCredentialManager
2626
from .interfaces import IMoonrakerConnectionStatusHandler
2727
from .jsonrpcresponse import JsonRpcResponse
2828
from .interfaces import IMoonrakerClient

moonraker_octoeverywhere/moonrakercredentailmanager.py renamed to moonraker_octoeverywhere/moonrakercredentialmanager.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,8 @@ def _ReadSingleJsonObject(self, sock:Any) -> Optional[str]:
235235

236236
# Read one, add it to the buffer, and see if we are done.
237237
data = sock.recv(1)
238+
if not data:
239+
return None
238240
if data[0] == 3: # This is EXT aka End of text. It separates the json messages.
239241
return message.decode(encoding="utf-8")
240242
message += data

moonraker_octoeverywhere/moonrakerhost.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
from .moonrakerdatabase import MoonrakerDatabase
3636
from .webrequestresponsehandler import MoonrakerWebRequestResponseHandler
3737
from .moonrakerapirouter import MoonrakerApiRouter
38-
from .moonrakercredentailmanager import MoonrakerCredentialManager
38+
from .moonrakercredentialmanager import MoonrakerCredentialManager
3939
from .filemetadatacache import FileMetadataCache
4040
from .uiinjector import UiInjector
4141
from .interfaces import IMoonrakerConnectionStatusHandler

octoeverywhere/localip.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,12 @@ def TryToGetLocalIp() -> str:
2222

2323
# Find the local IP. Works on Windows and Linux. Always gets the correct routable IP.
2424
# https://stackoverflow.com/a/28950776
25-
s = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
2625
ip = ""
2726
try:
2827
# doesn't even have to be reachable
29-
s.connect(('1.1.1.1', 1))
30-
ip = s.getsockname()[0]
28+
with socket.socket(socket.AF_INET, socket.SOCK_DGRAM) as s:
29+
s.connect(("1.1.1.1", 1))
30+
ip = s.getsockname()[0]
3131
except Exception:
3232
pass
33-
finally:
34-
s.close()
3533
return str(ip)

octoeverywhere/printinfo.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ def SetEstFilamentUsageMm(self, estMm:int) -> None:
111111
def GetEstFilamentWeightUsageMg(self) -> int:
112112
return self.Data.get(PrintInfo.c_EstFilamentWeightMg, 0)
113113
def SetEstFilamentWeightUsageMg(self, estG:int) -> None:
114-
if self.GetEstFilamentUsageMm() != estG:
114+
if self.GetEstFilamentWeightUsageMg() != estG:
115115
self.Data[PrintInfo.c_EstFilamentWeightMg] = estG
116116
self.Save()
117117

@@ -142,7 +142,7 @@ def Save(self) -> bool:
142142
json.dump(self.Data, f)
143143
return True
144144
except Exception as e:
145-
self.Logger.error(f"Failed to write print context from file. {e}")
145+
self.Logger.error(f"Failed to write print context to file. {e}")
146146
return False
147147

148148

0 commit comments

Comments
 (0)