fix(core): remove testing export from posthog-core (#2370)

Author: hpouillot

.changeset/early-carrots-bet.md

@@ -0,0 +1,5 @@
+---
+'@posthog/core': patch
+---
+
+remove testing export

.changeset/itchy-keys-remain.md

@@ -0,0 +1,5 @@
+---
+'posthog-node': patch
+---
+
+remove testing from posthog-core

packages/core/package.json

@@ -12,7 +12,8 @@
   },
   "files": [
     "dist",
-    "src"
+    "src",
+    "!src/__tests__"
   ],
   "scripts": {
     "clean": "rimraf dist",

packages/core/src/index.ts

@@ -2,7 +2,6 @@ export { getFeatureFlagValue } from './featureFlagUtils'
 export * from './utils'
 export * as ErrorTracking from './error-tracking'
 export { uuidv7 } from './vendor/uuidv7'
-export * as testing from './testing'
 export * from './posthog-core'
 export * from './posthog-core-stateless'
 export * from './types'

packages/node/src/__tests__/extensions/sentry-integration.spec.ts

@@ -1,6 +1,6 @@
 import { PostHog } from '@/entrypoints/index.node'
 import { PostHogSentryIntegration } from '@/extensions/sentry-integration'
-import { testing } from '@posthog/core'
+import { waitForPromises } from '../utils'
 
 jest.mock('../../version', () => ({ version: '1.2.3' }))
 
@@ -108,9 +108,9 @@ describe('PostHogSentryIntegration', () => {
 
     processorFunction(createMockSentryException())
 
-    await testing.waitForPromises() // First flush
+    await waitForPromises() // First flush
     jest.runOnlyPendingTimers() // Flush timer
-    await testing.waitForPromises() // Second flush
+    await waitForPromises() // Second flush
     const batchEvents = getLastBatchEvents()
 
     expect(batchEvents).toEqual([

packages/node/src/__tests__/feature-flags.flags.spec.ts

@@ -1,7 +1,6 @@
 import { PostHog } from '@/entrypoints/index.node'
 import { PostHogOptions } from '@/types'
-import { apiImplementation, apiImplementationV4 } from './utils'
-import { testing } from '@posthog/core'
+import { apiImplementation, apiImplementationV4, waitForPromises } from './utils'
 import { PostHogV2FlagsResponse } from '@posthog/core'
 
 jest.spyOn(console, 'debug').mockImplementation()
@@ -36,7 +35,7 @@ describe('flags v2', () => {
       expect(result).toBe(undefined)
       expect(mockedFetch).toHaveBeenCalledWith('http://example.com/flags/?v=2&config=true', expect.any(Object))
 
-      await testing.waitForPromises()
+      await waitForPromises()
       expect(capturedMessage).toMatchObject({
         distinct_id: 'some-distinct-id',
         event: '$feature_flag_called',
@@ -150,7 +149,7 @@ describe('flags v2', () => {
         expect(result).toBe(expectedResponse)
         expect(mockedFetch).toHaveBeenCalledWith('http://example.com/flags/?v=2&config=true', expect.any(Object))
 
-        await testing.waitForPromises()
+        await waitForPromises()
         expect(capturedMessage).toMatchObject({
           distinct_id: 'some-distinct-id',
           event: '$feature_flag_called',
@@ -213,7 +212,7 @@ describe('flags v2', () => {
         expect(result).toEqual([0, 1, 2])
         expect(mockedFetch).toHaveBeenCalledWith('http://example.com/flags/?v=2&config=true', expect.any(Object))
 
-        await testing.waitForPromises()
+        await waitForPromises()
         expect(capturedMessage).toBeUndefined()
       })
     })
@@ -300,7 +299,7 @@ describe('flags v2', () => {
         })
 
         await posthog.getFeatureFlag('error-flag', 'some-distinct-id')
-        await testing.waitForPromises()
+        await waitForPromises()
         expect(capturedMessage).toBeUndefined()
       })
     })
@@ -326,7 +325,7 @@ describe('flags v1', () => {
       expect(result).toBe(undefined)
       expect(mockedFetch).toHaveBeenCalledWith('http://example.com/flags/?v=2&config=true', expect.any(Object))
 
-      await testing.waitForPromises()
+      await waitForPromises()
       expect(capturedMessage).toMatchObject({
         distinct_id: 'some-distinct-id',
         event: '$feature_flag_called',
@@ -372,7 +371,7 @@ describe('flags v1', () => {
       expect(result).toEqual([0, 1, 2])
       expect(mockedFetch).toHaveBeenCalledWith('http://example.com/flags/?v=2&config=true', expect.any(Object))
 
-      await testing.waitForPromises()
+      await waitForPromises()
       expect(capturedMessage).toBeUndefined()
     })
   })

packages/node/src/__tests__/feature-flags.spec.ts

@@ -5,8 +5,7 @@ import {
   InconclusiveMatchError,
   relativeDateParseForFeatureFlagMatching,
 } from '@/extensions/feature-flags/feature-flags'
-import { anyFlagsCall, anyLocalEvalCall, apiImplementation } from './utils'
-import { testing } from '@posthog/core'
+import { anyFlagsCall, anyLocalEvalCall, apiImplementation, waitForPromises } from './utils'
 
 jest.spyOn(console, 'debug').mockImplementation()
 
@@ -1900,7 +1899,7 @@ describe('local evaluation', () => {
     posthog.on('localEvaluationFlagsLoaded', eventHandler)
 
     // Wait for initial load
-    await testing.waitForPromises()
+    await waitForPromises()
 
     expect(eventHandler).toHaveBeenCalledWith(2) // Should be called with number of flags loaded
   })
@@ -1920,7 +1919,7 @@ describe('local evaluation', () => {
     posthog.on('localEvaluationFlagsLoaded', eventHandler)
 
     // Wait for initial load
-    await testing.waitForPromises()
+    await waitForPromises()
 
     expect(eventHandler).not.toHaveBeenCalled()
   })
@@ -1956,7 +1955,7 @@ describe('local evaluation', () => {
     posthog.on('localEvaluationFlagsLoaded', eventHandler)
 
     // Wait for initial load
-    await testing.waitForPromises()
+    await waitForPromises()
     eventHandler.mockClear() // Clear initial call
 
     // Reload flags
@@ -2021,7 +2020,7 @@ describe('getFeatureFlag', () => {
       })
     ).toEqual(true)
 
-    await testing.waitForPromises()
+    await waitForPromises()
 
     expect(capturedMessage).toMatchObject({
       distinct_id: 'some-distinct-id',