Merge pull request #1383 from narengogi/fix/falsy-check-bedrock

VisargD · web-flow · commit 2c12cd2d2aea · 2025-10-22T17:46:37.000+05:30
fix falsy check in bedrock
diff --git a/src/providers/bedrock/utils.ts b/src/providers/bedrock/utils.ts
@@ -85,10 +85,10 @@ export const transformInferenceConfig = (
   if (params['stop']) {
     inferenceConfig['stopSequences'] = params['stop'];
   }
-  if (params['temperature']) {
+  if (params['temperature'] !== null && params['temperature'] !== undefined) {
     inferenceConfig['temperature'] = params['temperature'];
   }
-  if (params['top_p']) {
+  if (params['top_p'] !== null && params['top_p'] !== undefined) {
     inferenceConfig['topP'] = params['top_p'];
   }
   return inferenceConfig;
@@ -101,7 +101,7 @@ export const transformAdditionalModelRequestFields = (
     params.additionalModelRequestFields ||
     params.additional_model_request_fields ||
     {};
-  if (params['top_k']) {
+  if (params['top_k'] !== null && params['top_k'] !== undefined) {
     additionalModelRequestFields['top_k'] = params['top_k'];
   }
   if (params['response_format']) {
@@ -117,7 +117,7 @@ export const transformAnthropicAdditionalModelRequestFields = (
     params.additionalModelRequestFields ||
     params.additional_model_request_fields ||
     {};
-  if (params['top_k']) {
+  if (params['top_k'] !== null && params['top_k'] !== undefined) {
     additionalModelRequestFields['top_k'] = params['top_k'];
   }
   if (params['anthropic_version']) {

Original file line number	Diff line number	Diff line change
`@@ -85,10 +85,10 @@ export const transformInferenceConfig = (`
`85`	`85`	`if (params['stop']) {`
`86`	`86`	`inferenceConfig['stopSequences'] = params['stop'];`
`87`	`87`	`}`
`88`		`- if (params['temperature']) {`
	`88`	`+ if (params['temperature'] !== null && params['temperature'] !== undefined) {`
`89`	`89`	`inferenceConfig['temperature'] = params['temperature'];`
`90`	`90`	`}`
`91`		`- if (params['top_p']) {`
	`91`	`+ if (params['top_p'] !== null && params['top_p'] !== undefined) {`
`92`	`92`	`inferenceConfig['topP'] = params['top_p'];`
`93`	`93`	`}`
`94`	`94`	`return inferenceConfig;`
`@@ -101,7 +101,7 @@ export const transformAdditionalModelRequestFields = (`
`101`	`101`	`params.additionalModelRequestFields \|\|`
`102`	`102`	`params.additional_model_request_fields \|\|`
`103`	`103`	`{};`
`104`		`- if (params['top_k']) {`
	`104`	`+ if (params['top_k'] !== null && params['top_k'] !== undefined) {`
`105`	`105`	`additionalModelRequestFields['top_k'] = params['top_k'];`
`106`	`106`	`}`
`107`	`107`	`if (params['response_format']) {`
`@@ -117,7 +117,7 @@ export const transformAnthropicAdditionalModelRequestFields = (`
`117`	`117`	`params.additionalModelRequestFields \|\|`
`118`	`118`	`params.additional_model_request_fields \|\|`
`119`	`119`	`{};`
`120`		`- if (params['top_k']) {`
	`120`	`+ if (params['top_k'] !== null && params['top_k'] !== undefined) {`
`121`	`121`	`additionalModelRequestFields['top_k'] = params['top_k'];`
`122`	`122`	`}`
`123`	`123`	`if (params['anthropic_version']) {`