Skip to content

Commit ce8b3c7

Browse files
committed
- created now called at createdCallback time.
- removed deprecated entered|leftDocument; update to use entered|leftView.
1 parent f28f584 commit ce8b3c7

File tree

2 files changed

+4
-23
lines changed

2 files changed

+4
-23
lines changed

src/instance/base.js

Lines changed: 2 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,15 @@
1010
PolymerBase: true,
1111
job: Polymer.job,
1212
super: Polymer.super,
13-
// TODO(sorvell): bc, created is currently a synonym for 'ready'.
14-
// We should call this in createdCallback instead of at ready time or
15-
// eliminate it.
13+
// user entry point for element has had its createdCallback called
1614
created: function() {
1715
},
1816
// user entry point for element has shadowRoot and is ready for
1917
// api interaction
2018
ready: function() {
2119
},
2220
createdCallback: function() {
21+
this.created();
2322
if (this.ownerDocument.defaultView || this.alwaysPrepare ||
2423
preparingElements > 0) {
2524
this.prepareElement();
@@ -45,8 +44,6 @@
4544
preparingElements--;
4645
// user entry point
4746
this.ready();
48-
// TODO(sorvell): bc
49-
this.created();
5047
},
5148
enteredViewCallback: function() {
5249
if (!this._elementPrepared) {
@@ -57,14 +54,6 @@
5754
if (this.enteredView) {
5855
this.enteredView();
5956
}
60-
// TODO(sorvell): bc
61-
if (this.enteredDocument) {
62-
this.enteredDocument();
63-
}
64-
},
65-
// TODO(sorvell): bc
66-
enteredDocumentCallback: function() {
67-
this.enteredViewCallback();
6857
},
6958
leftViewCallback: function() {
7059
if (!this.preventDispose) {
@@ -74,14 +63,6 @@
7463
if (this.leftView) {
7564
this.leftView();
7665
}
77-
// TODO(sorvell): bc
78-
if (this.leftDocument) {
79-
this.leftDocument();
80-
}
81-
},
82-
// TODO(sorvell): bc
83-
leftDocumentCallback: function() {
84-
this.leftViewCallback();
8566
},
8667
// recursive ancestral <element> initialization, oldest first
8768
parseDeclarations: function(p) {

test/html/bind-object-repeat.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
enteredView: function() {
2222
console.log(this.localName + ': enteredView!');
2323
},
24-
created: function() {
24+
ready: function() {
2525
console.log(this.localName + ': created!');
2626
}
2727
})
@@ -41,7 +41,7 @@
4141
Polymer('x-bind-obj', {
4242
testObj: null,
4343
arr: null,
44-
created: function() {
44+
ready: function() {
4545
this.testObj = {foo: 'single'};
4646
this.arr = [
4747
{foo: 'array 0'},

0 commit comments

Comments
 (0)