Skip to content

Commit 9c7492d

Browse files
authored
Merge pull request #5559 from Polymer/compile
Add @OverRide, remove @attribute/@group/@hero/@homepage
2 parents 8af0ec4 + ed7709f commit 9c7492d

File tree

5 files changed

+6
-0
lines changed

5 files changed

+6
-0
lines changed

lib/elements/dom-module.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ function styleOutsideTemplateCheck(inst) {
7070
*/
7171
export class DomModule extends HTMLElement {
7272

73+
/** @override */
7374
static get observedAttributes() { return ['id']; }
7475

7576
/**

lib/legacy/legacy-element-mixin.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -519,6 +519,7 @@ export const LegacyElementMixin = dedupingMixin((base) => {
519519
* @this {Element}
520520
* @return {?Node} The element whose local dom within which this element is
521521
* contained.
522+
* @override
522523
*/
523524
get domHost() {
524525
let root = wrap(this).getRootNode();

lib/legacy/mutable-data-behavior.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ export const MutableDataBehavior = {
7070
* @param {*} old Previous property value
7171
* @return {boolean} Whether the property should be considered a change
7272
* @protected
73+
* @override
7374
*/
7475
_shouldPropertyChange(property, value, old) {
7576
return mutablePropertyChange(this, property, value, old, true);
@@ -142,6 +143,7 @@ export const OptionalMutableDataBehavior = {
142143
* @param {*} old Previous property value
143144
* @return {boolean} Whether the property should be considered a change
144145
* @protected
146+
* @override
145147
*/
146148
_shouldPropertyChange(property, value, old) {
147149
return mutablePropertyChange(this, property, value, old, this.mutableData);

lib/mixins/element-mixin.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -370,6 +370,7 @@ export const ElementMixin = dedupingMixin(base => {
370370
}
371371
}
372372

373+
/** @override */
373374
this.prototype._template = template;
374375
}
375376

lib/utils/templatize.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -300,6 +300,7 @@ class TemplateInstanceBase extends templateInstanceBase {
300300
*
301301
* @param {Event} event Event to dispatch
302302
* @return {boolean} Always true.
303+
* @override
303304
*/
304305
dispatchEvent(event) { // eslint-disable-line no-unused-vars
305306
return true;

0 commit comments

Comments
 (0)